Dead code

[sbryngelson]

Dead code needs to me removed. We seem to have thousands of lines of it. Here is one example:

MFC/src/simulation_code/m_rhs.f90

Lines 358 to 544 in fc40cce

	!$acc enter data create(qL_cons_n(i)%vf(1:sys_size))
	!$acc enter data create(qR_cons_n(i)%vf(1:sys_size))
	!$acc enter data create(qL_prim_n(i)%vf(1:sys_size))
	!$acc enter data create(qR_prim_n(i)%vf(1:sys_size))
	!$acc enter data create(myflux_vf(i)%vf(1:sys_size))
	!$acc enter data create(myflux_src_vf(i)%vf(1:sys_size))
	!!!!! Comment out qL_cons and qL_prim since we have flattened
	! do l = 1, sys_size
	! allocate (myflux_vf(i)%vf(l)%sf( &
	! ix%beg:ix%end, &
	! iy%beg:iy%end, &
	! iz%beg:iz%end))
	! allocate (myflux_src_vf(i)%vf(l)%sf( &
	! ix%beg:ix%end, &
	! iy%beg:iy%end, &
	! iz%beg:iz%end))
	!!$acc enter data create(myflux_vf(i)%vf(l)%sf(ix%beg:ix%end,iy%beg:iy%end,iz%beg:iz%end))
	!!$acc enter data create(myflux_src_vf(i)%vf(l)%sf(ix%beg:ix%end,iy%beg:iy%end,iz%beg:iz%end))
	! end do
	! if (i == 1) then
	! do l = 1, cont_idx%end
	! allocate (qL_cons_n(i)%vf(l)%sf( &
	! ix%beg:ix%end, &
	! iy%beg:iy%end, &
	! iz%beg:iz%end))
	! allocate (qR_cons_n(i)%vf(l)%sf( &
	! ix%beg:ix%end, &
	! iy%beg:iy%end, &
	! iz%beg:iz%end))
	!!$acc enter data create(qL_cons_n(i)%vf(l)%sf(ix%beg:ix%end,iy%beg:iy%end,iz%beg:iz%end))
	!!$acc enter data create(qR_cons_n(i)%vf(l)%sf(ix%beg:ix%end,iy%beg:iy%end,iz%beg:iz%end))
	! end do
	! if (weno_vars == 1) then
	! do l = mom_idx%beg, E_idx
	! allocate (qL_cons_n(i)%vf(l)%sf( &
	! ix%beg:ix%end, &
	! iy%beg:iy%end, &
	! iz%beg:iz%end))
	! allocate (qR_cons_n(i)%vf(l)%sf( &
	! ix%beg:ix%end, &
	! iy%beg:iy%end, &
	! iz%beg:iz%end))
	!!$acc enter data create(qL_cons_n(i)%vf(l)%sf(ix%beg:ix%end,iy%beg:iy%end,iz%beg:iz%end))
	!!$acc enter data create(qR_cons_n(i)%vf(l)%sf(ix%beg:ix%end,iy%beg:iy%end,iz%beg:iz%end))
	! end do
	! end if
	! do l = mom_idx%beg, E_idx
	! allocate (qL_prim_n(i)%vf(l)%sf( &
	! ix%beg:ix%end, &
	! iy%beg:iy%end, &
	! iz%beg:iz%end))
	! allocate (qR_prim_n(i)%vf(l)%sf( &
	! ix%beg:ix%end, &
	! iy%beg:iy%end, &
	! iz%beg:iz%end))
	!!$acc enter data create(qL_prim_n(i)%vf(l)%sf(ix%beg:ix%end,iy%beg:iy%end,iz%beg:iz%end))
	!!$acc enter data create(qR_prim_n(i)%vf(l)%sf(ix%beg:ix%end,iy%beg:iy%end,iz%beg:iz%end))
	! end do
	! if (model_eqns == 3) then
	! do l = internalEnergies_idx%beg, internalEnergies_idx%end
	! allocate (qL_prim_n(i)%vf(l)%sf( &
	! ix%beg:ix%end, &
	! iy%beg:iy%end, &
	! iz%beg:iz%end))
	! allocate (qR_prim_n(i)%vf(l)%sf( &
	! ix%beg:ix%end, &
	! iy%beg:iy%end, &
	! iz%beg:iz%end))
	!!$acc enter data create(qL_prim_n(i)%vf(l)%sf(ix%beg:ix%end,iy%beg:iy%end,iz%beg:iz%end))
	!!$acc enter data create(qR_prim_n(i)%vf(l)%sf(ix%beg:ix%end,iy%beg:iy%end,iz%beg:iz%end))
	! end do
	! end if
	! do l = adv_idx%beg, sys_size
	! allocate (qL_cons_n(i)%vf(l)%sf( &
	! ix%beg:ix%end, &
	! iy%beg:iy%end, &
	! iz%beg:iz%end))
	! allocate (qR_cons_n(i)%vf(l)%sf( &
	! ix%beg:ix%end, &
	! iy%beg:iy%end, &
	! iz%beg:iz%end))
	!!$acc enter data create(qL_cons_n(i)%vf(l)%sf(ix%beg:ix%end,iy%beg:iy%end,iz%beg:iz%end))
	!!$acc enter data create(qR_cons_n(i)%vf(l)%sf(ix%beg:ix%end,iy%beg:iy%end,iz%beg:iz%end))
	! end do
	! if (bubbles) then
	! do l = bub_idx%beg, bub_idx%end
	! allocate (qL_prim_n(i)%vf(l)%sf( &
	! ix%beg:ix%end, &
	! iy%beg:iy%end, &
	! iz%beg:iz%end))
	! allocate (qR_prim_n(i)%vf(l)%sf( &
	! ix%beg:ix%end, &
	! iy%beg:iy%end, &
	! iz%beg:iz%end))
	!!$acc enter data create(qL_prim_n(i)%vf(l)%sf(ix%beg:ix%end,iy%beg:iy%end,iz%beg:iz%end))
	!!$acc enter data create(qR_prim_n(i)%vf(l)%sf(ix%beg:ix%end,iy%beg:iy%end,iz%beg:iz%end))
	! end do
	! end if
	! else
	! ! i /= 1
	! do l = 1, sys_size
	! qL_cons_n(i)%vf(l)%sf => &
	! qL_cons_n(1)%vf(l)%sf
	! qR_cons_n(i)%vf(l)%sf => &
	! qR_cons_n(1)%vf(l)%sf
	! qL_prim_n(i)%vf(l)%sf => &
	! qL_prim_n(1)%vf(l)%sf
	! qR_prim_n(i)%vf(l)%sf => &
	! qR_prim_n(1)%vf(l)%sf
	!!$acc enter data attach(qL_cons_n(i)%vf(l)%sf,qR_cons_n(i)%vf(l)%sf,qL_prim_n(i)%vf(l)%sf,qR_prim_n(i)%vf(l)%sf)
	! #ifdef _OPENACC
	! call acc_attach(qL_cons_n(i)%vf(l)%sf)
	! #endif
	! end do
	! if (any(Re_size > 0)) then
	! if (weno_vars == 1) then
	! do l = 1, mom_idx%end
	! allocate (qL_cons_n(i)%vf(l)%sf( &
	! ix%beg:ix%end, &
	! iy%beg:iy%end, &
	! iz%beg:iz%end))
	! allocate (qR_cons_n(i)%vf(l)%sf( &
	! ix%beg:ix%end, &
	! iy%beg:iy%end, &
	! iz%beg:iz%end))
	!!$acc enter data create(qL_cons_n(i)%vf(l)%sf(ix%beg:ix%end,iy%beg:iy%end,iz%beg:iz%end))
	!!$acc enter data create(qR_cons_n(i)%vf(l)%sf(ix%beg:ix%end,iy%beg:iy%end,iz%beg:iz%end))
	! end do
	! else
	! do l = mom_idx%beg, mom_idx%end
	! allocate (qL_prim_n(i)%vf(l)%sf( &
	! ix%beg:ix%end, &
	! iy%beg:iy%end, &
	! iz%beg:iz%end))
	! allocate (qR_prim_n(i)%vf(l)%sf( &
	! ix%beg:ix%end, &
	! iy%beg:iy%end, &
	! iz%beg:iz%end))
	!!$acc enter data create(qL_prim_n(i)%vf(l)%sf(ix%beg:ix%end,iy%beg:iy%end,iz%beg:iz%end))
	!!$acc enter data create(qR_prim_n(i)%vf(l)%sf(ix%beg:ix%end,iy%beg:iy%end,iz%beg:iz%end))
	! end do
	! if (model_eqns == 3) then
	! do l = internalEnergies_idx%beg, internalEnergies_idx%end
	! allocate (qL_prim_n(i)%vf(l)%sf( &
	! ix%beg:ix%end, &
	! iy%beg:iy%end, &
	! iz%beg:iz%end))
	! allocate (qR_prim_n(i)%vf(l)%sf( &
	! ix%beg:ix%end, &
	! iy%beg:iy%end, &
	! iz%beg:iz%end))
	!!$acc enter data create(qL_prim_n(i)%vf(l)%sf(ix%beg:ix%end,iy%beg:iy%end,iz%beg:iz%end))
	!!$acc enter data create(qR_prim_n(i)%vf(l)%sf(ix%beg:ix%end,iy%beg:iy%end,iz%beg:iz%end))
	! end do
	! end if
	! end if
	! end if
	! end if
	!if (DEBUG) print*, 'pointing prim to cons!'
	! do l = 1, cont_idx%end
	! qL_prim_n(i)%vf(l)%sf => &
	! qL_cons_n(i)%vf(l)%sf
	! qR_prim_n(i)%vf(l)%sf => &
	! qR_cons_n(i)%vf(l)%sf
	!!$acc enter data attach(qL_prim_n(i)%vf(l)%sf,qR_prim_n(i)%vf(l)%sf)
	! end do
	! do l = adv_idx%beg, adv_idx%end
	! qL_prim_n(i)%vf(l)%sf => &
	! qL_cons_n(i)%vf(l)%sf
	! qR_prim_n(i)%vf(l)%sf => &
	! qR_cons_n(i)%vf(l)%sf
	!!$acc enter data attach(qL_prim_n(i)%vf(l)%sf,qR_prim_n(i)%vf(l)%sf)
	! end do

We also have two entire RHS functions:

MFC/src/simulation_code/m_rhs.f90

Line 2928 in fc40cce

subroutine s_compute_rhs_full(q_cons_vf, q_prim_vf, rhs_vf, t_step) ! -------

MFC/src/simulation_code/m_rhs.f90

Line 1010 in fc40cce

subroutine s_compute_rhs(q_cons_vf, q_prim_vf, rhs_vf, t_step) ! -------

The unused one needs to be deleted.

I'd like to see a PR that deletes thousands of lines of unused code.

[sbryngelson]

Still more dead code! But going in the right direction.

[anshgupta1234]

Not sure if this is dead code, but src/simulation/m_variables_conversion and m_riemann_solvers has a subroutine s_compute_average_state and several variables like rho_avg_sf and vel_avg that are never used. Should I get rid of them?

[sbryngelson]

Possibly. Can you go back in the git history (perhaps looking at MFC-develop repo as well) and see when they were used? I assume, at some point, they were.

[sbryngelson]

Note on this issue: VSCode seems to be pretty good at finding variables that are declared multiple times (once globally and again locally) and finding unused variables. You will need the appropriate fypp extension for VSCode to do this for .fpp files, I think it is here.

At the same time, we should be a bit careful.
It will likely throw spurious unused warnings due to not recognizing preprocessing directives like #ifdef from C preprocessor statements.

[sbryngelson]

@anandrdbz remove _flat names in variables.