build: bump ffmt pin to 0.4.4#1644
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.
Updates the toolchain’s pinned ffmt version to include an upstream bugfix (indent leakage after certain single-line constructs) while keeping formatting checks stable.
Changes:
- Bump
ffmtpin from0.4.3to0.4.4in the toolchain dependencies.
Bumps the ffmt formatter pin in toolchain/pyproject.toml from 0.4.3 to 0.4.4 (fixes single-line-construct indent leak, sbryngelson/ffmt#5). Verified as a 0-change no-op on master formatting; Formatting/Lint Toolchain/Python 3.9-3.14 CI all green.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1644 +/- ##
=======================================
Coverage 60.95% 60.95%
=======================================
Files 83 83
Lines 20003 20003
Branches 2983 2983
=======================================
Hits 12193 12193
Misses 5782 5782
Partials 2028 2028 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Bumps the
ffmtpin intoolchain/pyproject.tomlfrom0.4.3to0.4.4.ffmt 0.4.4 fixes an indentation bug (sbryngelson/ffmt#5): a self-contained single-line construct like
do d = 1, n; s = s + d; end doleaked an indent level onto every following line, and the wrong output was idempotent — so it silently persisted in format-clean files and turned any later edit in the enclosing scope into a large re-indentation cascade.Impact on this repo: ffmt 0.4.4 produces zero formatting changes on the current
mastersource tree (verified: the fix only affects code parked in the buggy over-indented fixed point, whichmasterhas none of). Soffmt --checkshould stay green. The benefit is that when the AMR module (which contains such a construct) lands, its indentation will be correct instead of leaked.Released: https://github.com/sbryngelson/ffmt/releases/tag/v0.4.4