Skip to content

build: bump ffmt pin to 0.4.4#1644

Merged
sbryngelson merged 1 commit into
masterfrom
bump-ffmt-0.4.4
Jul 14, 2026
Merged

build: bump ffmt pin to 0.4.4#1644
sbryngelson merged 1 commit into
masterfrom
bump-ffmt-0.4.4

Conversation

@sbryngelson

Copy link
Copy Markdown
Member

Bumps the ffmt pin in toolchain/pyproject.toml from 0.4.3 to 0.4.4.

ffmt 0.4.4 fixes an indentation bug (sbryngelson/ffmt#5): a self-contained single-line construct like do d = 1, n; s = s + d; end do leaked an indent level onto every following line, and the wrong output was idempotent — so it silently persisted in format-clean files and turned any later edit in the enclosing scope into a large re-indentation cascade.

Impact on this repo: ffmt 0.4.4 produces zero formatting changes on the current master source tree (verified: the fix only affects code parked in the buggy over-indented fixed point, which master has none of). So ffmt --check should stay green. The benefit is that when the AMR module (which contains such a construct) lands, its indentation will be correct instead of leaked.

Released: https://github.com/sbryngelson/ffmt/releases/tag/v0.4.4

Copilot AI review requested due to automatic review settings July 14, 2026 22:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.

Updates the toolchain’s pinned ffmt version to include an upstream bugfix (indent leakage after certain single-line constructs) while keeping formatting checks stable.

Changes:

  • Bump ffmt pin from 0.4.3 to 0.4.4 in the toolchain dependencies.

@sbryngelson
sbryngelson merged commit eb79392 into master Jul 14, 2026
89 of 91 checks passed
@sbryngelson
sbryngelson deleted the bump-ffmt-0.4.4 branch July 14, 2026 23:16
sbryngelson added a commit to sbryngelson/MFC that referenced this pull request Jul 15, 2026
Bumps the ffmt formatter pin in toolchain/pyproject.toml from 0.4.3 to 0.4.4 (fixes single-line-construct indent leak, sbryngelson/ffmt#5). Verified as a 0-change no-op on master formatting; Formatting/Lint Toolchain/Python 3.9-3.14 CI all green.
@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.95%. Comparing base (e090d56) to head (fd0a4a7).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1644   +/-   ##
=======================================
  Coverage   60.95%   60.95%           
=======================================
  Files          83       83           
  Lines       20003    20003           
  Branches     2983     2983           
=======================================
  Hits        12193    12193           
  Misses       5782     5782           
  Partials     2028     2028           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants