Skip to content

feature/remove_by_condition - #6

Open
Schmluk wants to merge 1 commit into
mainfrom
feature/remove_by_condition
Open

feature/remove_by_condition#6
Schmluk wants to merge 1 commit into
mainfrom
feature/remove_by_condition

Conversation

@Schmluk

@Schmluk Schmluk commented Jul 9, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  • Add a more elegant remove if interface for blocks (for some reason standard erase/remove did not work, but this should be fairly efficient, too)
  • Added utest

@Schmluk
Schmluk requested a review from nathanhhughes July 9, 2024 07:29
nathanhhughes
nathanhhughes approved these changes Jul 9, 2024
View reviewed changes

@nathanhhughes nathanhhughes left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I like the new API!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nathanhhughes nathanhhughes nathanhhughes approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Schmluk @nathanhhughes