fix: seeding & setup

[AngeloTadeucci]

Summary by CodeRabbit

• New Features

  • Introduced the option to skip navigation mesh generation during program execution via a command-line argument.
  • Added user prompt in the initialization script to allow skipping navmesh generation.

• Enhancements

  • Improved error handling and logging for loading environment variables from a .env file, providing clearer user feedback.
  • Refined output messages in the program for better clarity regarding database connections.

• Project Structure

  • Removed unnecessary project entry for Maple2.Database.Seed from the solution file, streamlining the overall project structure.

[coderabbitai]

Walkthrough

The changes introduce command-line argument handling to skip navmesh processing in Program.cs, enhance error handling in the Dotenv class, remove a project from the solution file, and add a user prompt in the PowerShell setup script to decide on navmesh generation. These modifications improve the flexibility of program execution, user feedback, and streamline the project structure.

Changes

Files	Change Summary
Maple2.File.Ingest/Program.cs	Added command-line argument handling for skipping navmesh processing, introduced skipNavmesh variable, and refined output messages.
Maple2.Tools/Dotenv.cs	Enhanced error handling and logging in the Load method for .env file loading, with improved parsing logic and user feedback for invalid lines.
Maple2.sln	Removed the project entry for Maple2.Database.Seed, simplifying the project structure while retaining the Maple2.Server.DebugGame entry.
setup.ps1	Introduced a user prompt to decide on navmesh generation during initialization, modifying the command execution based on user input.

Poem

In the code where rabbits dwell,
New paths and choices weave their spell.
Skip the mesh, oh what a treat,
User control makes it all complete.
With each change, we hop with glee,
A brighter future, come see, come see! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b46814a and e9feabb.

Files selected for processing (4)

• Maple2.File.Ingest/Program.cs (4 hunks)
• Maple2.Tools/Dotenv.cs (2 hunks)
• Maple2.sln (2 hunks)
• setup.ps1 (2 hunks)

Files skipped from review due to trivial changes (1)

• Maple2.sln

Additional comments not posted (13)

Maple2.Tools/Dotenv.cs (4)

10-10: LGTM! Improved user feedback for missing .env file.

The added console output statement enhances user feedback by notifying them when the .env file is not found.

---

19-21: LGTM! Simplified parsing logic and improved feedback for invalid lines.

The modified parsing logic simplifies the code and provides clearer feedback about invalid lines in the .env file.

---

25-26: LGTM! Improved robustness in parsing key-value pairs.

The extraction and trimming of key-value pairs using the index of = improves the robustness of the parsing logic.

---

28-28: LGTM! Correctly setting environment variables.

The environment variable is correctly set using the parsed key-value pairs.

setup.ps1 (3)

137-140: LGTM! Enhanced user feedback for navmesh generation.

The added user prompt provides important information about the importance and time required for navmesh generation.

---

144-145: LGTM! Enhanced user interactivity for navmesh generation.

The added user prompt allows users to decide whether to skip navmesh generation, enhancing user interactivity.

---

147-151: LGTM! Enhanced user control over the initialization process.

The script conditionally executes commands based on the user's input, allowing users to skip or include navmesh generation.

Maple2.File.Ingest/Program.cs (6)

3-4: LGTM! Added necessary using directives.

The new using directives for System.Runtime.InteropServices and System.Text are necessary to support the new command execution logic for different operating systems.

---

22-28: LGTM! Introduced command-line argument handling for skipping navmesh processing.

The new boolean variable skipNavmesh and the command-line argument handling enhance the flexibility of program execution by allowing users to skip navmesh processing.

---

66-69: LGTM! Enhanced readability and maintainability for database migration command.

The use of worldServerDir and cmdCommand variables enhances readability and maintainability for the command to migrate the game database.

---

72-80: LGTM! Enhanced flexibility for command execution on different operating systems.

The updated command execution logic supports different operating systems, enhancing the flexibility of the program.

---

89-94: LGTM! Improved clarity for metadata database operations.

The use of the dataDbConnection variable and the updated connection to the metadata database improve clarity regarding the operations being performed.

---

142-144: LGTM! Conditional instantiation of NavMeshMapper based on user input.

The conditional instantiation of NavMeshMapper based on the value of skipNavmesh allows users to skip navmesh processing, enhancing the flexibility of the program.