Skip to content

Bump packages with vulnerabilities - #298

Merged
Zintixx merged 1 commit into
masterfrom
bump-packages
Jan 30, 2025
Merged

Bump packages with vulnerabilities#298
Zintixx merged 1 commit into
masterfrom
bump-packages

Conversation

@AngeloTadeucci

@AngeloTadeucci AngeloTadeucci commented Jan 29, 2025

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Chores
    • Updated gRPC and Protobuf package references across multiple server projects
    • Upgraded package versions for improved compatibility and potential performance enhancements
    • Specific package updates include:
      • Google.Protobuf: 3.22.0 → 3.29.3
      • Grpc packages: 2.51.0 → 2.67.0

@coderabbitai

coderabbitai Bot commented Jan 29, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

This pull request focuses on updating gRPC and Protobuf package references across multiple server project files in the Maple2 solution. The changes involve upgrading package versions for Google.Protobuf, Grpc.AspNetCore.HealthChecks, Grpc.AspNetCore.Server, Grpc.Net.ClientFactory, Grpc.Net.Client, and Grpc.Tools from their previous versions to newer releases, primarily moving from version 2.51.0 to 2.67.0 (or 3.29.3 for Protobuf).

Changes

File Change Summary
Maple2.Server.Core.csproj Updated package references:
- Google.Protobuf: 3.22.0 → 3.29.3
- Grpc.AspNetCore.HealthChecks: 2.51.0 → 2.67.0
- Grpc.AspNetCore.Server: 2.51.0 → 2.67.0
- Grpc.Net.ClientFactory: 2.51.0 → 2.67.0
- Grpc.Tools: 2.51.0 → 2.69.0
Maple2.Server.Game.csproj Updated package references:
- Grpc.AspNetCore.Server: 2.51.0 → 2.67.0
- Grpc.Net.Client: 2.51.0 → 2.67.0
Maple2.Server.Login.csproj Updated package reference:
- Grpc.Net.Client: 2.51.0 → 2.67.0
Maple2.Server.World.csproj Updated package references:
- Grpc.AspNetCore.Server: 2.51.0 → 2.67.0
- Grpc.Net.Client: 2.51.0 → 2.67.0

Possibly related PRs

Suggested reviewers

  • Zintixx

Poem

🐰 Hop, hop, packages upgrade!
Grpc versions dance and parade
From old to new, they smoothly glide
Dependencies now fortified
A rabbit's code update delight! 🚀


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 88db3b4 and a77ac26.

📒 Files selected for processing (4)
  • Maple2.Server.Core/Maple2.Server.Core.csproj (1 hunks)
  • Maple2.Server.Game/Maple2.Server.Game.csproj (1 hunks)
  • Maple2.Server.Login/Maple2.Server.Login.csproj (1 hunks)
  • Maple2.Server.World/Maple2.Server.World.csproj (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: format
  • GitHub Check: build
🔇 Additional comments (4)
Maple2.Server.Core/Maple2.Server.Core.csproj (1)

14-18: LGTM! Package updates look good.

The coordinated update of gRPC packages to version 2.67.0 and Google.Protobuf to 3.29.3 is consistent and addresses security vulnerabilities. The versions are compatible with each other.

Let's verify if these are the latest stable versions and check for any known vulnerabilities:

✅ Verification successful

✅ Package versions are up-to-date and secure

The package updates are using the latest stable versions:

  • gRPC packages at 2.67.0 match the latest stable release
  • Google.Protobuf 3.29.3 aligns with latest protobuf release (v29.3)
  • No known vulnerabilities found
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check NuGet for latest versions and known vulnerabilities
curl -s https://api.nuget.org/v3/registration5-gz-semver2/grpc.aspnetcore.server/index.json | jq -r '.items[0].items[-1].catalogEntry.version'
curl -s https://api.nuget.org/v3/registration5-gz-semver2/google.protobuf/index.json | jq -r '.items[0].items[-1].catalogEntry.version'

# Check GitHub Security Advisories
gh api graphql -f query='
{
  securityVulnerabilities(first: 5, ecosystem: NUGET, package: "Grpc.AspNetCore.Server") {
    nodes {
      advisory {
        summary
        severity
        publishedAt
      }
      vulnerableVersionRange
      firstPatchedVersion {
        identifier
      }
    }
  }
}'

Length of output: 652


Script:

#!/bin/bash
# Try alternative NuGet API endpoint for gRPC
curl -s "https://api-v2v3search-0.nuget.org/query?q=packageid:Grpc.AspNetCore.Server&prerelease=false" | jq -r '.data[0].version'

# Check GitHub releases
gh api repos/grpc/grpc-dotnet/releases/latest | jq -r '.tag_name'
gh api repos/protocolbuffers/protobuf/releases/latest | jq -r '.tag_name'

Length of output: 292

Maple2.Server.Login/Maple2.Server.Login.csproj (1)

13-13: LGTM! Package version aligns with Core project.

The update of Grpc.Net.Client to version 2.67.0 is consistent with the updates in the Core project.

Maple2.Server.World/Maple2.Server.World.csproj (1)

14-15: LGTM! Package versions align with other projects.

The updates of both Grpc.AspNetCore.Server and Grpc.Net.Client to version 2.67.0 are consistent with the updates in Core and Login projects.

Maple2.Server.Game/Maple2.Server.Game.csproj (1)

23-24: LGTM! Package versions align with other projects.

The updates of both Grpc.AspNetCore.Server and Grpc.Net.Client to version 2.67.0 maintain consistency across all projects in the solution.

Summary of package updates across all projects:

  • All gRPC runtime packages updated to 2.67.0
  • Grpc.Tools updated to 2.69.0
  • Google.Protobuf updated to 3.29.3

These coordinated updates address security vulnerabilities while maintaining version compatibility across the solution.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Zintixx
Zintixx merged commit df13b75 into master Jan 30, 2025
@AngeloTadeucci
AngeloTadeucci deleted the bump-packages branch February 2, 2025 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants