Fix Portal Cubes

[AngeloTadeucci]

For cube portals we were assuming only CubePortalSettings or InteractCube would exist when both are needed

Summary by CodeRabbit

• Refactor

  • Consolidated cube configuration by replacing a generic settings property with distinct options for portal configurations and interactive features.
  • Streamlined conversion logic to ensure consistent handling of cube data.

• Tests

  • Added tests verifying accurate transformations between numeric and vector representations.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request removes the CubeHelper static class and its GetCubeSettings method, eliminates JSON polymorphism attributes from cube setting records, and updates the cube model classes. The changes replace the generic CubeSettings property in both HomeLayoutCube and UgcMapCube with a more explicit CubePortalSettings property and add a new Interact property. Additionally, new tests for vector conversion logic have been introduced.

Changes

File(s)	Change Summary
Maple2.Database/Extensions/CubeHelper.cs	Deleted the static CubeHelper class and its GetCubeSettings method.
Maple2.Database/Model/Map/CubePortalSettings.cs	Removed JSON polymorphism attributes; updated record signatures for CubePortalSettings and InteractCube by removing the abstract CubeSettings base class.
Maple2.Database/Model/Map/HomeLayoutCube.cs, …/UgcMapCube.cs	Updated implicit conversion operators and JSON configuration: replaced CubeSettings with CubePortalSettings and added a new Interact property.
Maple2.Server.Tests/Vector/Vector3BTests.cs	Added new test class Vector3BTests with methods to verify integer-to-sbyte conversion and vice versa for Vector3B.

Sequence Diagram(s)

sequenceDiagram
    participant HL as HomeLayoutCube
    participant PC as PlotCube
    HL->>PC: Convert to PlotCube\n(Map CubePortalSettings & Interact)
    PC->>HL: Convert to HomeLayoutCube\n(Extract CubePortalSettings & Interact)

Loading

sequenceDiagram
    participant UMC as UgcMapCube
    participant PC as PlotCube
    UMC->>PC: Convert to PlotCube\n(Map CubePortalSettings & Interact)
    PC->>UMC: Convert to UgcMapCube\n(Extract CubePortalSettings & Interact)

Loading

Possibly related PRs

• Feat: portal cubes #264 – Involves similar modifications to cube handling by transitioning from CubeSettings to domain-specific properties and removing the GetCubeSettings method.

Suggested reviewers

• Zintixx

Poem

I'm a rabbit with a coding hop,
Leaping through changes with a joyful bop!
Old helpers vanish, new fields bloom,
In our digital warren there's always room.
Hoppy code days, let the bytes zoom!
🐰💻

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between feeebc6 and bcb0005.

⛔ Files ignored due to path filters (3)

• Maple2.Server.World/Migrations/20250214234115_CubeInteract.Designer.cs is excluded by !Maple2.Server.World/Migrations/*
• Maple2.Server.World/Migrations/20250214234115_CubeInteract.cs is excluded by !Maple2.Server.World/Migrations/*
• Maple2.Server.World/Migrations/Ms2ContextModelSnapshot.cs is excluded by !Maple2.Server.World/Migrations/*

📒 Files selected for processing (5)

• Maple2.Database/Extensions/CubeHelper.cs (0 hunks)
• Maple2.Database/Model/Map/CubePortalSettings.cs (2 hunks)
• Maple2.Database/Model/Map/HomeLayoutCube.cs (4 hunks)
• Maple2.Database/Model/Map/UgcMapCube.cs (4 hunks)
• Maple2.Server.Tests/Vector/Vector3BTests.cs (1 hunks)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.