Fix ingest running before downloading server files in setup.ps1

[mouzedrift]

Summary by CodeRabbit

• Chores
  • Updated the setup process to streamline the download of essential server files during installation, ensuring a consistent and efficient initialization flow.

[coderabbitai]

Walkthrough

The setup.ps1 script has been updated to replace the old code block responsible for downloading customized server files with a new block. The new section uses a Write-Host command to indicate the commencement of the download process followed by four Invoke-WebRequest commands to retrieve Server.m2d, Server.m2h, Xml.m2d, and Xml.m2h into a directory defined by $dataPath. The overall script structure remains unchanged.

Changes

File	Change Summary
setup.ps1	Removed the old download block and replaced it with a new section that begins with a Write-Host announcement, followed by four Invoke-WebRequest commands to download Server.m2d, Server.m2h, Xml.m2d, and Xml.m2h to $dataPath.

Possibly related PRs

• Update setup.ps1 #349: Involved similar modifications in the setup.ps1 script focusing on downloading customized server files via Invoke-WebRequest.

Suggested reviewers

• Zintixx
• AngeloTadeucci

Poem

In fields of code, I hop with glee,
Downloading treasures for our server tree.
Each command a gentle nibble of byte,
Fresh downloads springing into sight.
I twirl in ASCII, joyful and keen—
A bunny’s code dance, lively and clean!

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

setup.ps1 (1)

136-142: Reordering Download Block and Error Handling Suggestion

The new block correctly places the download process before initiating the ingest, which addresses the PR objective of preventing ingest from running before the necessary server files have been downloaded. However, since these downloads are critical for subsequent steps, it would be prudent to add error handling to catch any issues during the download process. This enhancement would help avoid running the ingest phase if a file fails to download.

Suggested improvement:
Wrap the Invoke-WebRequest calls in a try/catch block. For example:

-Write-Host "Downloading customized server files..."
-Invoke-WebRequest -Uri "https://github.com/Zintixx/MapleStory2-XML/releases/latest/download/Server.m2d" -OutFile (Join-Path $dataPath "Server.m2d")
-Invoke-WebRequest -Uri "https://github.com/Zintixx/MapleStory2-XML/releases/latest/download/Server.m2h" -OutFile (Join-Path $dataPath "Server.m2h")
-Invoke-WebRequest -Uri "https://github.com/Zintixx/MapleStory2-XML/releases/latest/download/Xml.m2d" -OutFile (Join-Path $dataPath "Xml.m2d")
-Invoke-WebRequest -Uri "https://github.com/Zintixx/MapleStory2-XML/releases/latest/download/Xml.m2h" -OutFile (Join-Path $dataPath "Xml.m2h")
+Write-Host "Downloading customized server files..."
+try {
+    Invoke-WebRequest -Uri "https://github.com/Zintixx/MapleStory2-XML/releases/latest/download/Server.m2d" -OutFile (Join-Path $dataPath "Server.m2d")
+    Invoke-WebRequest -Uri "https://github.com/Zintixx/MapleStory2-XML/releases/latest/download/Server.m2h" -OutFile (Join-Path $dataPath "Server.m2h")
+    Invoke-WebRequest -Uri "https://github.com/Zintixx/MapleStory2-XML/releases/latest/download/Xml.m2d" -OutFile (Join-Path $dataPath "Xml.m2d")
+    Invoke-WebRequest -Uri "https://github.com/Zintixx/MapleStory2-XML/releases/latest/download/Xml.m2h" -OutFile (Join-Path $dataPath "Xml.m2h")
+} catch {
+    Write-Host "Error downloading server files: $($_.Exception.Message)" -ForegroundColor Red
+    exit 1
+}

This addition ensures that any failure in downloading the files is caught, and the script halts gracefully instead of proceeding with ingest operations.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between aa35d2d and 0080ad3.

📒 Files selected for processing (1)

• setup.ps1 (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build