feat: add error handling for calculate damage

[AngeloTadeucci]

Summary by CodeRabbit

• New Features

  • Added detailed string representations for NPCs and players, making it easier to view their current state and attributes.

• Bug Fixes

  • Improved error handling during damage calculations to prevent crashes and ensure stability if an error occurs.

[coderabbitai]

Walkthrough

Exception handling was added to damage calculation logic in both the ApplyDamage method and the DotDamageRecord constructor to prevent unhandled exceptions from disrupting execution. Additionally, ToString() overrides were introduced for FieldNpc and FieldPlayer classes to provide detailed string representations for debugging purposes.

Changes

File(s)	Change Summary
.../Actor/Actor.cs .../Skill/DotDamageRecord.cs	Wrapped damage calculation logic in try-catch blocks; errors are logged, and damage defaults to zero on failure.
.../Actor/FieldNpc.cs	Added ToString() override to provide formatted string output for NPCs.
.../Actor/FieldPlayer.cs	Added ToString() override to provide detailed multi-line string output for players.

Suggested reviewers

• Zintixx

Poem

In fields and fights where damage flies,
Now errors meet a gentler guise.
With logs and strings, we debug with glee,
NPCs and players tell their story, see?
No crash, just calm, as bunnies cheer—
Code is safer, spring is near! 🐇✨

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

Maple2.Server.Game/Model/Field/Actor/Actor.cs (1)

116-123: Good exception handling with minor suggestion.

The try-catch block effectively prevents crashes during damage calculation and provides detailed error logging. Setting damageAmount = 0 as fallback is appropriate to prevent erroneous damage application.

However, note that when an exception occurs, the damage record (targetRecord.AddDamage) isn't updated, but damageAmount is reset to 0, which could lead to inconsistency between recorded damage and actual health modification. Consider if the damage record should also be updated in the catch block.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 34a6cd2 and 7f8d62c.

📒 Files selected for processing (4)

• Maple2.Server.Game/Model/Field/Actor/Actor.cs (1 hunks)
• Maple2.Server.Game/Model/Field/Actor/FieldNpc.cs (1 hunks)
• Maple2.Server.Game/Model/Field/Actor/FieldPlayer.cs (1 hunks)
• Maple2.Server.Game/Model/Skill/DotDamageRecord.cs (2 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

Maple2.Server.Game/Model/Field/Actor/Actor.cs (2)

Maple2.Server.Game/Util/DamageCalculator.cs (2)

• DamageType (11-147)
• DamageCalculator (10-148)

Maple2.Server.Game/Model/Skill/DamageRecord.cs (1)

• AddDamage (58-60)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: build
• GitHub Check: build

🔇 Additional comments (4)

Maple2.Server.Game/Model/Field/Actor/FieldNpc.cs (1)

474-476: LGTM! Good debugging enhancement.

The ToString() override provides comprehensive debug information including NPC metadata and state details. This will be valuable for debugging NPC behavior and state tracking.

Maple2.Server.Game/Model/Field/Actor/FieldPlayer.cs (1)

652-658: LGTM! Excellent debugging enhancement.

The ToString() override provides comprehensive debug information with well-organized multi-line formatting. The inclusion of position, state, flags, permissions, and debug flags will be invaluable for debugging player-related issues.

Maple2.Server.Game/Model/Skill/DotDamageRecord.cs (2)

5-5: Good addition for error handling support.

Adding the Serilog import to support the new exception logging functionality.

---

35-43: Excellent exception handling implementation.

The try-catch block follows the same robust pattern established in Actor.cs. The error logging provides valuable debugging context, and the fallback to hpAmount = 0 prevents DOT effects from causing crashes or applying erroneous damage when calculation failures occur.