Bug fixes

[AngeloTadeucci]

• Added a print inventory command
• Discard items that would not be added to inventory because of overflow (should never happen in normal gameplay situations)
• Fixed bank expanded slots
• Enchanting with fodders now can't go past 30% change
• Condition field_mission added

Summary by CodeRabbit

• New Features

  • Added a command to print detailed inventory contents for a specified tab via the debug interface.
  • Introduced a method to display inventory details, including item attributes and summary information.

• Bug Fixes

  • Improved inventory overflow handling by discarding excess items and logging a warning.

• Enhancements

  • Storage capacity now accurately reflects expansions stored in the database.
  • Success rate contributions from fodder additions are now capped for specific enchant types.
  • FieldMission quest completions now trigger an additional condition update notification.

[coderabbitai]

Walkthrough

This update refactors array initializations and logic in item enchantment and storage management, introduces inventory overflow handling, and adds a new print-inventory debug command. It also provides a method for formatted inventory output and updates quest completion condition handling for field missions.

Changes

File(s)	Change Summary
Maple2.Server.Game/Manager/ItemEnchantManager.cs	Simplified array initializations; updated fodder addition logic to cap success rate; no public API changes.
Maple2.Server.Game/Manager/Items/InventoryManager.cs	Changed overflow handling to discard items; added Print(InventoryType type) method for formatted inventory output.
Maple2.Server.Game/Manager/Items/StorageManager.cs	Storage size now initialized based on database expansion value.
Maple2.Server.Game/Manager/QuestManager.cs	Reformatted quest completion check; added extra condition update for FieldMission quests upon completion.
Maple2.Server.Game/Commands/DebugCommand.cs	Added print-inventory subcommand for printing inventory tab contents; handles parsing and error reporting.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant DebugCommand
    participant InventoryManager

    User->>DebugCommand: print-inventory <tab>
    DebugCommand->>InventoryManager: Print(tab)
    InventoryManager-->>DebugCommand: Formatted inventory string
    DebugCommand-->>User: Output inventory details or error

Loading

Possibly related PRs

• AngeloTadeucci/Maple2#452: Improves logging in InventoryManager.cs and fixes namespace declarations; related via InventoryManager.cs but does not overlap in logic or features.

Poem

In the warren of code, a new path unfurled,
Inventories print, their secrets twirled.
Overflow now swept with a gentle paw,
Quests and enchantments obey the law.
With debug in paw and carrots in sight,
This bunny keeps Maple2 running just right! 🥕

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

Maple2.Server.Game/Commands/DebugCommand.cs (1)

415-429: Consider more specific exception handling.

The implementation is solid overall, but catching SystemException is overly broad and may mask specific issues.

Consider replacing the broad exception handling with more specific exceptions:

-            } catch (SystemException ex) {
+            } catch (ArgumentException ex) {
                ctx.Console.Error.WriteLine(ex.Message);
                ctx.ExitCode = 1;
+            } catch (InvalidOperationException ex) {
+                ctx.Console.Error.WriteLine($"Inventory operation failed: {ex.Message}");
+                ctx.ExitCode = 1;
            }

This provides better error specificity while still handling likely failure scenarios from inventory operations.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cf22a0b and ad17035.

📒 Files selected for processing (1)

• Maple2.Server.Game/Commands/DebugCommand.cs (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: build
• GitHub Check: build
• GitHub Check: format

🔇 Additional comments (2)

Maple2.Server.Game/Commands/DebugCommand.cs (2)

36-36: LGTM: Command registration follows established pattern.

The new PrintInventoryCommand is properly registered alongside other debug commands.

---

403-413: LGTM: Command setup follows established conventions.

The constructor properly initializes the command with appropriate name, description, and argument definition. The dynamic generation of valid inventory types in the argument description is a nice touch for user guidance.