Fix: dungeon migrating

[AngeloTadeucci]

Summary by CodeRabbit

• Bug Fixes

  • Improved exception handling to prevent unnecessary error logs during normal session shutdowns.

• Refactor

  • Updated class inheritance for improved consistency in packet handler structure.

[coderabbitai]

Walkthrough

The changes introduce targeted exception handling in the session networking code to silently handle a specific, expected exception during pipe reading. Additionally, the DungeonRoomHandler class is updated to inherit from a more general packet handler base class, adjusting its inheritance structure without altering its core logic.

Changes

File(s)	Change Summary
Maple2.Server.Core/Network/Session.cs	Added handling for a specific benign InvalidOperationException in async pipe reading to avoid unnecessary logs.
Maple2.Server.Game/PacketHandlers/DungeonRoomHandler.cs	Changed base class from FieldPacketHandler to PacketHandler<GameSession> and updated using directives.

Poem

In the warren of code, a tunnel was cleared,
Exceptions now handled, just as we feared.
Dungeon doors shifted, a handler anew,
Rabbits hop onward, with packets in view.
🐇✨ No more false alarms—just smoother terrain,
As network and dungeon both hop on the train!

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

Maple2.Server.Core/Network/Session.cs (1)

214-218: LGTM: Proper handling of expected reader completion exception.

The targeted exception handling correctly addresses the scenario where the pipe reader completes normally during session shutdown, preventing unnecessary error logging.

Consider making the exception message matching more robust:

-if (ex is InvalidOperationException invalidOperation && invalidOperation.Message.Contains("reader was completed")) {
+if (ex is InvalidOperationException invalidOperation && invalidOperation.Message.Contains("reader was completed", StringComparison.OrdinalIgnoreCase)) {

This ensures case-insensitive matching and makes the check slightly more resilient to minor message variations.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0d46f23 and adaa272.

📒 Files selected for processing (2)

• Maple2.Server.Core/Network/Session.cs (1 hunks)
• Maple2.Server.Game/PacketHandlers/DungeonRoomHandler.cs (1 hunks)

🧰 Additional context used

🧠 Learnings (3)

📓 Common learnings

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#199
File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0
Timestamp: 2024-07-12T04:31:25.376Z
Learning: Packets can't ever be null inside the `Handle` function of packet handlers in the repository.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#199
File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0
Timestamp: 2024-10-09T04:13:28.776Z
Learning: Packets can't ever be null inside the `Handle` function of packet handlers in the repository.

Maple2.Server.Game/PacketHandlers/DungeonRoomHandler.cs (2)

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#199
File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0
Timestamp: 2024-07-12T04:31:25.376Z
Learning: Packets can't ever be null inside the `Handle` function of packet handlers in the repository.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#199
File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0
Timestamp: 2024-10-09T04:13:28.776Z
Learning: Packets can't ever be null inside the `Handle` function of packet handlers in the repository.

Maple2.Server.Core/Network/Session.cs (2)

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#199
File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0
Timestamp: 2024-10-09T04:13:28.776Z
Learning: Packets can't ever be null inside the `Handle` function of packet handlers in the repository.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#199
File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0
Timestamp: 2024-07-12T04:31:25.376Z
Learning: Packets can't ever be null inside the `Handle` function of packet handlers in the repository.

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: build
• GitHub Check: build

🔇 Additional comments (5)

Maple2.Server.Game/PacketHandlers/DungeonRoomHandler.cs (4)

4-4: LGTM: Required using directive for inheritance change.

The new using directive is necessary to support the inheritance change to PacketHandler<GameSession>.

---

10-10: ```shell
#!/bin/bash

Display the DungeonRoomHandler implementation

rg -A 10 -B 2 "class DungeonRoomHandler" --type cs

Display the PacketHandler base class definition

rg -A 5 -B 5 "public abstract class PacketHandler" --type cs

---

`4-4`: **LGTM: Using statement supports the inheritance change.**

The addition of the using directive for `Maple2.Server.Core.PacketHandlers` properly supports the updated inheritance structure.

---

`10-10`: **LGTM: Inheritance refactoring aligns with core architecture.**

The change from `FieldPacketHandler` to `PacketHandler<GameSession>` makes the handler more generic and aligns with the updated core packet handling architecture. The existing `Handle` method signature remains compatible with the new base class.

</details>
<details>
<summary>Maple2.Server.Core/Network/Session.cs (1)</summary>

`214-218`: **LGTM: Proper handling of expected reader completion exception.**

The targeted exception handling correctly identifies and silently handles the "reader was completed" `InvalidOperationException` that occurs during normal session shutdown. This prevents unnecessary error logging while preserving error handling for genuine exceptions.

</details>

</blockquote></details>

</details>

<!-- This is an auto-generated comment by CodeRabbit for review status -->