Fix: Disable giving Mastery on low tier gathering objects

[Zintixx]

Summary by CodeRabbit

• Bug Fixes

  • Adjusted mastery point rewards for gathering activities. Players will no longer receive mastery points for Farming, Mining, Gathering, or Breeding if their mastery level is three or more levels above the recipe's mastery reward. Mastery points for other activities remain unchanged.

• New Features

  • Introduced a new mastery differential factor system to better regulate mastery point awards based on player and recipe mastery levels.

[coderabbitai]

Walkthrough

The update introduces a new data structure for mastery differential factors and integrates it into the mastery point awarding logic. It adds a conditional check in the GatherCommon method to prevent awarding mastery points for Farming, Mining, Gathering, and Breeding if the player's mastery level exceeds the recipe's reward by a threshold derived from the new differential factor table. The change also includes metadata, mapping, and serialization support for the new table.

Changes

File(s)	Change Summary
Maple2.Server.Game/Manager/MasteryManager.cs	Modified GatherCommon to conditionally restrict mastery point rewards based on mastery differential factors
Maple2.Database/Storage/Metadata/TableMetadataStorage.cs	Added lazy-loaded property and backing field for MasteryDifferentialFactorTable
Maple2.File.Ingest/Mapper/TableMapper.cs	Added mapping and parsing logic for MASTERYT_DIFFERENTIAL_FACTOR table
Maple2.Model/Common/TableNames.cs	Added constant string for MASTERYT_DIFFERENTIAL_FACTOR XML table name
Maple2.Model/Metadata/Table/MasteryDifferentialFactorTable.cs	Added new record type MasteryDifferentialFactorTable with nested Entry record
Maple2.Model/Metadata/TableMetadata.cs	Added JSON polymorphic derived type mapping for MasteryDifferentialFactorTable

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~15 minutes

Poem

A rabbit paused to ponder well,
When mastery points should rise or quell.
With factors mapped and thresholds set,
Rewards now balance, none forget.
In code’s vast field, the bunny hops,
Ensuring fairness never stops.
🥕🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c8d28ad and 44e3772.

📒 Files selected for processing (6)

• Maple2.Database/Storage/Metadata/TableMetadataStorage.cs (3 hunks)
• Maple2.File.Ingest/Mapper/TableMapper.cs (2 hunks)
• Maple2.Model/Common/TableNames.cs (1 hunks)
• Maple2.Model/Metadata/Table/MasteryDifferentialFactorTable.cs (1 hunks)
• Maple2.Model/Metadata/TableMetadata.cs (1 hunks)
• Maple2.Server.Game/Manager/MasteryManager.cs (1 hunks)

✅ Files skipped from review due to trivial changes (4)

• Maple2.Model/Common/TableNames.cs
• Maple2.Model/Metadata/TableMetadata.cs
• Maple2.Model/Metadata/Table/MasteryDifferentialFactorTable.cs
• Maple2.Database/Storage/Metadata/TableMetadataStorage.cs

🚧 Files skipped from review as they are similar to previous changes (1)

• Maple2.Server.Game/Manager/MasteryManager.cs

🔇 Additional comments (2)

Maple2.File.Ingest/Mapper/TableMapper.cs (2)

62-62: LGTM! Table mapping follows established patterns.

The new table mapping for MASTERYT_DIFFERENTIAL_FACTOR correctly follows the established pattern used throughout the file and is appropriately placed near other mastery-related table mappings.

---

780-788: LGTM! Parser method implementation is consistent and well-structured.

The ParseMasteryDifferentialFactor() method follows the established patterns used throughout the file:

• Consistent naming convention
• Standard dictionary creation and population approach
• Proper entry construction with named parameters
• Follows the same error handling approach as other parser methods

The implementation correctly maps the parsed data into the expected table structure.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch mastery-fix

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 053f8e5 and c8d28ad.

📒 Files selected for processing (1)

• Maple2.Server.Game/Manager/MasteryManager.cs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: build
• GitHub Check: build

🔇 Additional comments (2)

Maple2.Server.Game/Manager/MasteryManager.cs (2)

140-153: LGTM! Well-implemented mastery gating logic.

The conditional check effectively prevents mastery exploitation by blocking rewards when players are significantly overleveled. The logic correctly:

• Targets appropriate gathering mastery types (Farming, Mining, Gathering, Breeding)
• Uses a reasonable 3-level threshold to determine when content is too low-tier
• Returns early to skip mastery rewards while still allowing successful gathering

---

154-154: Correct placement of mastery increment.

Moving the mastery increment after the conditional check ensures that mastery points are only awarded when the level gap check passes. This maintains the intended behavior while preserving the original flow for non-gated mastery types.