Bugfixes of final and intermediate madspace output - #188
theoheimel wants to merge 2 commits into
Conversation
|
For the first point, I would agree if we offer smart plot by default (So I'm working to update the histogram mode to be more automatic --and check if it can handle scale/pdf uncertainty--). I also think that we should offer a simple way for the user to decide if those are ON/OFF by default (different use case/user might not like the default in the same way, will be in the same update) For the second point, I just do not agree on it, I do not see the point for a crash, If the user ask for a shower/... we should make it work (how we make it work we can discuss, but it is pointless to make it crash). |
oliviermattelaer
left a comment
There was a problem hiding this comment.
The main point is to put back (in one way or another) an automatic switch to lhe when asking for shower or MadAnalysis5, (MadSpin?), ...
|
Heads-up: #190 is stacked on this branch ( It touches two things from here:
The rest of #190 is the mg7 |
|
My issue with the old system with just a warning is that the user will probably overlook it and then be surprised the output format is wrong. That's what happened for me and why I changed it. Since the numpy output only turns on when the user explicitly requests it (which means they want numpy and not LHE), I don't think it should be quietly changed back. So at least in non-interactive mode it should be a crash. |
|
Should not we put npy as the default output (if not shower/...) |
|
Yes, we could consider that. I find it much nicer to use to make plots, inspect the data, etc. |
Take #188's header.lhe (LHE <header>/<init> written next to npy events), ExRoot-off-by-default and prompt cleanup of the per-channel npy files. Conflicts: - keep the automatic switch to LHE (force_lhe_output_if_needed) instead of #188's check_lhe_output_required error: with npy the default, raising would stop every run that turns a shower on; - drop lhe_meta.json: npy_to_lhe now copies header.lhe verbatim (it carries the cards, beams, cross section, MG7Seed and <initrwgt>) and takes the rwgt columns from the npy dtype; lhe_completer.json is kept for compact_npy (save_lhe_completer); - output_format default stays lhe_npy, with #188's comment. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Superseded by #195, which merges this branch in (header.lhe, ExRoot off by default, per-channel npy cleanup). One deliberate change: the automatic switch to LHE output is kept instead of raising an error, since npy is now the default. header.lhe also replaced the lhe_meta.json #195 had added, and the gridpack header is now complete. |
header.lhewith no events but the LHE header/init information.