Recommit missing mcap import - #508
Merged
Merged
Conversation
michalpelka
force-pushed
the
mp/mcap_import
branch
from
August 28, 2026 16:23
699a4e9 to
7851f37
Compare
Signed-off-by: Michal Pelka <michalpelka@gmail.com>
michalpelka
force-pushed
the
mp/mcap_import
branch
from
August 28, 2026 20:57
7851f37 to
1ae550a
Compare
On Windows fs::remove fails while a file still has an open handle, so the four reader tests that kept a McapFileReader alive across the trailing fs::remove(path) threw "The process cannot access the file because it is being used by another process" and failed CI. Wrap the reader usage in a block so its destructor closes the file before the delete, matching the pattern the writer tests already use. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UbQZSR1ok4bBMBEd5uvHDM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recommitted code that I missed somehow in #496