Skip to content

Upgrade to jvm17 - #38

Open
clitnak wants to merge 4 commits into
MasterControlIncPublic:mc-masterfrom
clitnak:mc-java17
Open

Upgrade to jvm17#38
clitnak wants to merge 4 commits into
MasterControlIncPublic:mc-masterfrom
clitnak:mc-java17

Conversation

@clitnak

@clitnak clitnak commented Jan 25, 2024

Copy link
Copy Markdown
  • Upgraded gradle from 4 to 7
  • Tried to be a little aggressive with brining build-time support to jvm 17, specifically removed nashorn dependencies and reimplemented differently.

@kylec32

kylec32 commented Jan 25, 2024

Copy link
Copy Markdown
Collaborator

For my own education. Is there a particular reason you went to 7.3.3 (which was released Dec 22, 2021). Did you try to go further and ran into issues or just went to a version that was the minimal required and called that good?

I'm not too worried about being on a 2 year old version (we have been OK with being on a 5 year old version), just want to know for future work (internal) work.

@clitnak

clitnak commented Jan 25, 2024

Copy link
Copy Markdown
Author

The scenario was:

Issue came up.
Googled issue.
Solved by upgrading to gradle 7.
Upgraded to gradle 7
Solved
(more issues ensued, but that is a different story, if I upgraded to the bleeding edge, the issues would have increased, for certain)

I'll circle back and see what a larger gradle upgrade would entail, but technically that is out of scope.

@kylec32

kylec32 commented Jan 25, 2024

Copy link
Copy Markdown
Collaborator

I'll circle back and see what a larger gradle upgrade would entail, but technically that is out of scope.

Yep. Don't even worry about circling back, that explanation gives me what I wanted which is, "We don't know for sure there are issue with additional upgrades (likely are) but didn't try". If Gradle 7 gives us what we need for this update (it seems to) we are good with Gradle 7

Fixed most pending deprecated methods.
fixed warnings for a clean build.
@clitnak
clitnak marked this pull request as ready for review February 1, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants