Spin the refresh icon in place - #90
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rotating "refresh endpoints" spinner drifted off centre as it turned.
text-3is0.75rem, and the root font-size is 13px, sopresetIcons'1.2embox came out 11.7px. A mask that size resamples to a slightly different centre at each angle, so the icon orbited rather than spun in place. Both refresh-cw icons in the sidebar now use a whole-pixelw-12px h-12pxbox.Measured in headless Chrome with this repo's generated UnoCSS — centroid of the rendered icon across 12 angles:
text-3)w-12px h-12px)pnpm checkpasses. Measured in Chromium rather than the WKWebView the app actually ships in, but the cause — a fractional-pixel mask box — is engine-independent.