Skip to content

fix: Remove the legacy digest bodies and keys of the news notifications - EXO-90072 - eXIP7.3.0.22 - #913

Merged
azayati merged 1 commit into
feature/experiencefrom
exip-7.3.0.22-cleanup-legacy-digest
Sep 9, 2026
Merged

azayati merged 1 commit into
feature/experiencefrom
exip-7.3.0.22-cleanup-legacy-digest

Conversation

@azayati

@azayati azayati commented Sep 8, 2026

Copy link
Copy Markdown
Member

Depends on Meeds-io/commons#782 (the legacy makeDigest hook becomes a concrete deprecated no-op there). Until it is merged this branch does not compile against the feature branch, hence the draft. Task EXO-90072, spec 50469 §5.

What

  • MailTemplateProvider: makeDigest override and buildDigestMsg helper removed, with the imports and the SpaceService dependency that only served them (constructor and test adapted).
  • PushTemplateProvider: the no-op makeDigest override.
  • News_en.properties: the 3 legacy Notification.digest.one.* keys. The same keys are removed in the 40 locale files of the bundle.

Untouched: NewsDigestLinePlugin, its Kernel declaration and its digest.* keys, every makeMessage path and template.

Checked

content-service compiles; MailTemplateProviderTest and NewsDigestLinePluginTest are green (the JPA container tests fail identically on the base branch locally, stale social snapshot).

N2 (addon, no schema, no security). 🤖 Generated with Claude Code

@azayati
azayati force-pushed the exip-7.3.0.22-cleanup-legacy-digest branch from abb41f1 to 8897610 Compare September 8, 2026 14:20
…ns - EXO-90072 - eXIP7.3.0.22

The mail template provider loses its makeDigest override, its buildDigestMsg
helper and the SpaceService dependency that only served them; the push
provider loses its empty override. The 3 legacy Notification.digest keys are
removed in the 40 locales of the news bundle.

The new NewsDigestLinePlugin, its Kernel declaration and its digest keys are
untouched, as is every makeMessage path.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@azayati
azayati force-pushed the exip-7.3.0.22-cleanup-legacy-digest branch from 8897610 to 41edf59 Compare September 8, 2026 19:57
@azayati
azayati marked this pull request as ready for review September 9, 2026 09:10
@azayati
azayati merged commit 9431221 into feature/experience Sep 9, 2026
0 of 2 checks passed
@azayati
azayati deleted the exip-7.3.0.22-cleanup-legacy-digest branch September 9, 2026 15:20
exo-swf pushed a commit that referenced this pull request Sep 9, 2026
azayati added a commit that referenced this pull request Sep 10, 2026
exo-swf pushed a commit that referenced this pull request Sep 11, 2026
azayati added a commit that referenced this pull request Sep 11, 2026
…ns - EXO-90072 - eXIP7.3.0.22 (#913)

(cherry picked from commit 9431221)
(cherry picked from commit bf67953)
exo-swf pushed a commit that referenced this pull request Sep 14, 2026
azayati added a commit that referenced this pull request Sep 15, 2026
…ns - EXO-90072 - eXIP7.3.0.22 (#913)

(cherry picked from commit 9431221)
(cherry picked from commit bf67953)
(cherry picked from commit 45fc2db)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant