fix: Remove the legacy digest hooks of the notifications - EXO-90072 - eXIP7.3.0.22 - #2004
Merged
Merged
Conversation
EXO-90072 - eXIP7.3.0.22 The digest engine of commons was removed in eXIP 7.3.0.22 and the makeDigest hook went with it, so the overrides this addon carried are dropped along with the imports that only served them. No behaviour change: the engine had been switched off since 2022 and these overrides were never called. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
azayati
force-pushed
the
exip-7.3.0.22-cleanup-legacy-digest
branch
from
September 8, 2026 20:24
0db1005 to
37c26db
Compare
azayati
marked this pull request as ready for review
September 9, 2026 09:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The digest engine of commons was switched off in 2022 (its job crons were pushed to year 2099) and eXIP 7.3.0.22 removes it, replaced by
io.meeds.commons.digest.makeDigestwas an abstract method ofAbstractNotificationPlugin/AbstractTemplateBuilder, so every notification plugin had to implement it: this addon carried overrides that were never called. They go, with the imports that only served them.Changed: 5 files changed, 4 insertions(+), 62 deletions(-) — ActionAnnouncedTemplateBuilder.java,ActionPublishedTemplateBuilder.java ContributionAcceptedTemplateBuilder.java,ContributionRejectedTemplateBuilder.java AbstractPluginTest.java
No behaviour change: the instant emails and the push notifications are untouched, and this addon has no digest translation key.
Checked
Built against the cleaned commons and social of the same wave, in a cross-repository build that installs each repository in dependency order (commons → social → the addons) to prove the whole set compiles together.
N2 (addon, no schema, no security). 🤖 Generated with Claude Code