fix: Remove the legacy digest hook of the notification builder - EXO-90072 - eXIP7.3.0.22 - #595
Merged
Conversation
…90072 - eXIP7.3.0.22 The abstract makeDigest of the legacy digest engine is gone from commons-api (Meeds-io/commons#782): the empty override of MatrixTemplateBuilder does not compile any more, and it never produced anything. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
azayati
added a commit
that referenced
this pull request
Sep 11, 2026
exo-swf
pushed a commit
that referenced
this pull request
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
feature/experienceof matrix does not compile since Meeds-io/commons#782 removed the legacy digest engine:MatrixTemplateBuilder.makeDigest— an empty override returningfalse— no longer overrides anything.How
The override and the now unused
java.io.Writerimport are removed. Nothing else in matrix referenced the legacy digest (noisInDaily/isInWeekly, nostoreDigest, no digest keys in the bundles).Same change as the 17 other addon PRs of EXO-90072; matrix had been missed in the first inventory.
Checks
mvn install -pl servicesagainst the merged commons/social snapshots: compiles; 158 tests, 156 green. The 2 failures (MatrixInfectedFileCleanupListenerTest) are Windows-only — the listener matchesFile.separator + "synapse" + File.separatoragainst a/-separated path — and unrelated to this change; they pass on the Linux CI agents.🤖 Generated with Claude Code