fix: Remove the legacy digest bodies and keys of the task notifications - EXO-90072 - eXIP7.3.0.22 - #644
Merged
Conversation
azayati
force-pushed
the
exip-7.3.0.22-cleanup-legacy-digest
branch
from
September 8, 2026 14:20
2d36625 to
694706e
Compare
…ns - EXO-90072 - eXIP7.3.0.22 The mail template provider loses its makeDigest override and its two buildDigestMsg helpers, and with them the comment builder that held nothing else; the push provider loses its two empty overrides. The 12 legacy Notification.digest keys and the 5 labels only they read are removed in the 40 locales of the notification bundle. The new TaskDigestLinePlugin, its Kernel declaration and its digest keys are untouched, as is every makeMessage path. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
azayati
force-pushed
the
exip-7.3.0.22-cleanup-legacy-digest
branch
from
September 8, 2026 19:57
694706e to
df0c433
Compare
azayati
marked this pull request as ready for review
September 9, 2026 09:10
exo-swf
pushed a commit
that referenced
this pull request
Sep 9, 2026
…ns - EXO-90072 - eXIP7.3.0.22 (#644) > **Depends on Meeds-io/commons#782** (the legacy `makeDigest` hook becomes a concrete deprecated no-op there). Until it is merged this branch does not compile against the feature branch, hence the draft. Task EXO-90072, spec 50469 §5. ## What - `MailTemplateProvider`: the `makeDigest` override and the `buildDigestMsg` helpers are removed; the mail `CommentTemplateBuilder` only held a `buildDigestMsg` override, so it is gone and `TaskCommentPlugin` uses the plain `TemplateBuilder`. - `PushTemplateProvider`: the two no-op `makeDigest` overrides. - `TaskNotification_en.properties`: the 12 `Notification.digest.{one,more}.*` keys and 5 `Notification.label.*` keys (and, one.other, more.other, task, tasks) read only by the removed code (verified by grep over Java, gtmpl, JS, Vue). The same keys are removed in the 40 locale files of the bundle. - Tests: `testMakeDigest` removed (it only asserted the removed bodies). Untouched: `TaskDigestLinePlugin`, its Kernel declaration and its `digest.*` keys (the new digest of the eXIP), every `makeMessage` path. ## Checked `services` and `webapps` build; the 17 notification tests are green (the DAO container tests fail identically on the base branch locally, stale social snapshot). N2 (addon, no schema, no security). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
azayati
added a commit
that referenced
this pull request
Sep 10, 2026
…ns - EXO-90072 - eXIP7.3.0.22 (#644) > **Depends on Meeds-io/commons#782** (the legacy `makeDigest` hook becomes a concrete deprecated no-op there). Until it is merged this branch does not compile against the feature branch, hence the draft. Task EXO-90072, spec 50469 §5. ## What - `MailTemplateProvider`: the `makeDigest` override and the `buildDigestMsg` helpers are removed; the mail `CommentTemplateBuilder` only held a `buildDigestMsg` override, so it is gone and `TaskCommentPlugin` uses the plain `TemplateBuilder`. - `PushTemplateProvider`: the two no-op `makeDigest` overrides. - `TaskNotification_en.properties`: the 12 `Notification.digest.{one,more}.*` keys and 5 `Notification.label.*` keys (and, one.other, more.other, task, tasks) read only by the removed code (verified by grep over Java, gtmpl, JS, Vue). The same keys are removed in the 40 locale files of the bundle. - Tests: `testMakeDigest` removed (it only asserted the removed bodies). Untouched: `TaskDigestLinePlugin`, its Kernel declaration and its `digest.*` keys (the new digest of the eXIP), every `makeMessage` path. ## Checked `services` and `webapps` build; the 17 notification tests are green (the DAO container tests fail identically on the base branch locally, stale social snapshot). N2 (addon, no schema, no security). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> (cherry picked from commit 5beb448)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
MailTemplateProvider: themakeDigestoverride and thebuildDigestMsghelpers are removed; the mailCommentTemplateBuilderonly held abuildDigestMsgoverride, so it is gone andTaskCommentPluginuses the plainTemplateBuilder.PushTemplateProvider: the two no-opmakeDigestoverrides.TaskNotification_en.properties: the 12Notification.digest.{one,more}.*keys and 5Notification.label.*keys (and, one.other, more.other, task, tasks) read only by the removed code (verified by grep over Java, gtmpl, JS, Vue). The same keys are removed in the 40 locale files of the bundle.testMakeDigestremoved (it only asserted the removed bodies).Untouched:
TaskDigestLinePlugin, its Kernel declaration and itsdigest.*keys (the new digest of the eXIP), everymakeMessagepath.Checked
servicesandwebappsbuild; the 17 notification tests are green (the DAO container tests fail identically on the base branch locally, stale social snapshot).N2 (addon, no schema, no security). 🤖 Generated with Claude Code