Conversation
- IssueDetailPage stat-row icons (ShieldCheck, Clock, GitBranch, MilestoneIcon) (MergeFi#433) - Navbar ChevronDown dropdown indicator (MergeFi#434) - StatCard icon prop wrapper (MergeFi#435) - ConnectPanel Code2/Wallet/CheckCircle2 icons (MergeFi#436) All icons are purely decorative, paired with adjacent text labels. Adding aria-hidden prevents screen readers from announcing unlabeled graphics as redundant noise. Closes MergeFi#433 Closes MergeFi#434 Closes MergeFi#435 Closes MergeFi#436
|
@ogundelevictory Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@ogundelevictory is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
aria-hidden="true"to decorative icons in four components:Why
All icons are purely decorative, immediately paired with text labels that convey the same information. Without
aria-hidden, screen readers announce unlabeled graphics as redundant noise. The StatCard fix (#435) is especially impactful since it's the shared component behind every stat tile across all dashboards.How to test
npx axe-coreor use browser DevTools accessibility inspector — no unlabeled graphic violations should remain on the affected pagesLinked issues
Closes #433
Closes #434
Closes #435
Closes #436