Add xAI Grok model support - #586
Merged
Merged
Conversation
Contributor
|
@dhvll is attempting to deploy a commit to the Merit Systems Team on Vercel. A member of the Team first needs to authorize it. |
rsproule
reviewed
Oct 20, 2025
rsproule
left a comment
Contributor
There was a problem hiding this comment.
missing:
- provider smoke test for xai
Comment on lines
+34
to
+48
| const tools = (reqBody as any)?.tools as unknown[] | undefined; | ||
| if (Array.isArray(tools)) { | ||
| const wantsWebSearch = tools.some(tool => { | ||
| const t = tool as any; | ||
| return ( | ||
| t?.type === 'web_search_preview' || t?.name === 'web_search_preview' | ||
| ); | ||
| }); | ||
| if (wantsWebSearch) { | ||
| (reqBody as any).search = true; | ||
| } | ||
| } | ||
| } catch (e) { | ||
| // best-effort; fall through | ||
| } |
Contributor
There was a problem hiding this comment.
unclear to me what is going on here? whats the idea?
Member
|
Related to #586 |
Contributor
Author
|
@rsproule can you review and tell me which changes needs to be done? |
Contributor
|
Cool just tested. LGTM. good work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #585