Skip to content

[TESTING PR] chore: test solana ci without the test environment variable - #83

Draft
Battambang wants to merge 1 commit into
chore/solana-wallet-snap-integrate-packagesfrom
spike/solana-tests-production-env
Draft

[TESTING PR] chore: test solana ci without the test environment variable#83
Battambang wants to merge 1 commit into
chore/solana-wallet-snap-integrate-packagesfrom
spike/solana-tests-production-env

Conversation

@Battambang

@Battambang Battambang commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

TESTING PR to try aligning Solana CI tests execution repo pattern.

This pull request includes updates to the workflow configuration and test utilities to improve consistency and simplify test setup. The main changes are focused on standardizing environment variables for API endpoints during builds and generalizing test utility values.

Workflow and environment improvements:

  • Standardized API base URLs for price, token, security alerts, and NFT APIs to use LOCAL_API_BASE_URL during the build process in .github/workflows/lint-build-test.yml, ensuring consistent test environments.
  • Updated the workflow to restore all snap.manifest.json files in any package after test builds, rather than only the Solana package, improving generality and preventing accidental changes.

Test utility update:

  • Changed the TEST_ORIGIN value in utils.ts from 'http://localhost:3000' to 'metamask', likely to better reflect the expected test environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant