Rename the remote transfer directory to winrm-upload-<host> - #151
Conversation
The SEN_ShareFor_<host>$ name (and its SEN_TempFor_/SEN_ cousins) was inherited from the ancient pre-2.0.0 SMB-share implementation; since no share is created anymore, the trailing $ (hidden-share convention) was meaningless for a plain directory. The winrm-upload- prefix is kept as short as SEN_ShareFor_ so the MAX_PATH staging budget is unchanged and the legacy SMB share name stays under the 80-character limit. Closes #150 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e7150a6a04
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| */ | ||
| static String buildShareName() { | ||
| return String.format("SEN_ShareFor_%s$", Utils.getComputerName()); | ||
| return String.format("winrm-upload-%s", Utils.getComputerName()); |
There was a problem hiding this comment.
For consumers of the public WindowsTempShare.getOrCreateShare(...) API, this changes both the created SMB share/returned UNC name and its visibility by dropping the trailing $; however, README.md was not updated, and the migration guide still promises that WindowsTempShare is unchanged. Add an upgrade notice explaining this compatibility change and the new visible share name, as required for end-user-facing changes.
AGENTS.md reference: AGENTS.md:L25-L27
Useful? React with 👍 / 👎.
…pgrade notes Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
@codex please review again |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Fixes #150
What
Renames the remote naming scheme inherited from the ancient pre-2.0.0 SMB-share implementation:
<windir>\Temp\SEN_ShareFor_<CLIENT>$<windir>\Temp\winrm-upload-<CLIENT><clusterShare>\Temp\SEN_TempFor_<CLIENT><clusterShare>\Temp\winrm-upload-<CLIENT>SEN_<CLIENT>_<time>_<random>winrm-<CLIENT>-<time>-<random>Since 2.0.0 no SMB share is created — files travel through the WinRM channel itself and land in a plain directory — so the old name was misleading and the trailing
$(the Windows hidden-share convention) was meaningless.Why
winrm-upload-and notwinrm-java-upload-The prefix is deliberately kept at 13 characters (the exact length of
SEN_ShareFor_):ShellFileCopy.maxRemoteNameLengthand its test;WindowsTempShare.getOrCreateShare()SMB flow (still public API, wherebuildShareName()is also the share name), the name stays under the 80-character share-name limit, whichwinrm-java-upload-would exceed for maximal computer names.Compatibility
file-transfers.md).preparing-the-host.mdupdated).Verification
mvn verify sitepasses: 186 unit tests + 1 IT, 0 failures; checkstyle/PMD/SpotBugs clean;mvn formatter:formatreports no changes.🤖 Generated with Claude Code