Fix truncated authentication.html: promote Ordered fallback to h2 - #154
Merged
Conversation
Doxia cannot handle the h1 -> h3 heading skip and silently dropped everything after the intro from the generated page. Fixes #153 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #153
Problem
https://metricshub.org/winrm-java/authentication.html only renders the introduction — everything from "Ordered fallback" to "See also" is missing from the generated HTML, and the sidebar TOC contains a broken
href="#null"entry.Cause
authentication.mdhad### Ordered fallbackdirectly under the top-level#title with no##parent section. Doxia's section nesting cannot handle the h1 → h3 skip followed by a return to h2: it emits an empty<section></section>and silently drops the rest of the page.Fix
Promote the heading to
## Ordered fallback. A scan of all pages undersrc/site/markdown/confirms this was the only heading-level skip in the site.Verification
Rebuilt the site locally with
mvn site: the regeneratedauthentication.htmlnow contains all seven sections (Ordered fallback, User name and domain, NTLM, Kerberos (SPNEGO), Authentication failures, Choosing the scheme on the command line, See also), the Kerberos configuration subsection, and the CLI options table, with no#nullTOC entries.🤖 Generated with Claude Code