You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Short PR to allow SPARKDASH_TOKEN env variable to be injected inside the docker-compose.yml service. Without that, adding the variable inside .env is not recognized, making it impossible to start.
Real gap: the README tells operators to set BIND_HOST=0.0.0.0andSPARKDASH_TOKEN for shared access, but the compose file never passed the token into the container, so that path failed closed no matter what went into .env.
Checked that the ${SPARKDASH_TOKEN:-} default cannot make an install look authenticated: configuredToken() is (process.env.SPARKDASH_TOKEN || "").trim() and startupPreflight uses Boolean(process.env.SPARKDASH_TOKEN || process.env.DASHBOARD_TOKEN), so unset and empty both read as "no token".
Suite on your branch: 314/314 server + 23/23 frontend; merges clean against current main. Landing it in a batch merge — thank you. docker-compose.dev.yml has the same gap if you want it in this same PR (loopback is the default there, so lower stakes).
Landed via #107 (Batch B ACK merge onto main) as eeca4ed — its branch carried a main merge, so only the one commit was taken, and the single conflict (where SPARKDASH_TOKEN slots into the compose env list) was resolved by keeping both lines. Closing this one as superseded — thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short PR to allow
SPARKDASH_TOKENenv variable to be injected inside thedocker-compose.ymlservice. Without that, adding the variable inside.envis not recognized, making it impossible to start.