Migrate weather icons to IconManager

[MidnightJava]

Migrate weather icons to IconManager, after it's implemented. Convert patterns.py icons to JSON format + update the time-weather plugin to use IconManager.load_icon()

[sjjh]

Not sure about sizing of the (future') icons. I was wondering if below the symbol there would be space for an arrow (probably 3 or 4 leds high pointing north; cf screen shot), showing the wind direction and below the wind speed (probably no space to display a unit, but maybe there is a default unit per locale, or users can set it manually and thus learn it).

[sjjh]

If space is needed, maybe it works to gain two pixels in height by down scaling the °-symbol. Cf. screenshot for comparison:

[MidnightJava]

The weather icons are six pixels high. I think adding wind speed and direction would be nice, but available space depends on how many digits the temp takes. Two-digit negative values will require three characters (although the negative sign is just one row). These are not unusual in winter for most locales, although they are more common with Celsius than Fahrenheit.

Currently, even some parts of weather icons will not fit when there is a three-digit temp value. If that happens, it will not cause an error. The undisplayable part will just be truncated. In the future, when we come up with a scrolling symbol implementation, we could use that to accommodate more space.

We'll probably hold off on adding wind info until we implement the icon manager and revisit the weather icons, which are just quickly implemented placeholders now. I'll keep the issue open.

[sjjh]

The weather icons are six pixels high.

Then I have another issue over here... For me it's only 3 pixels high. Probably something is wrong with my config, to show the complete weather widget. Could you please have a quick look on my config, if you spot a mistake? Or do you have another idea to debug?

# Default duration value, overridden by per-app values if present
duration: 10

# Configure apps to be displayed on each quadrant. Optionally cycle though multiple apps
# according to a configured time duration in seconds. App names must be unique within a quadrant.
quadrants:
  top-left:
  - app:
    name: time
    duration: 30
    # Render on the entire panel. Make sure the lower quadrant has display: false
    scope: panel
    # args must be mappings, not lists
    args:
      fmt_24_hour: true
      # Enter a timezone string from the IANA time zone database, e.g. "America/New_York" or "GMT"
      # See https://en.wikipedia.org/wiki/List_of_tz_database_time_zones#Time_zone_abbreviations
      # If omitted or no value, your locale timezone will be used
      timezone:
  - app:
    name: cpu
    duration: 30
    animate: false
      #- app:
      #name: snap
    # duration: 5
    # If true, scroll the display
    #animate: true
    #scope: panel
    #args:
    #file: zigzag.json
    #path: snapshot_files/left
    #panel: left
  top-right:
  - app:
    name: weather
    duration: 30
    scope: panel
    args:
      # Specify zip and country code or lat/lon, for weather lookup.
      # Or set IP_LOCATE_API_KEY env var to lookup your location by IP
      # Either way, you need to set OPENWEATHER_API_KEY for weather lookup (see .env-example  )
      # See https://www.iban.com/country-codes for ISO 3166 country codes (use digraph)
      # zip_info: ["your zip", "your country code"]
      # lat_lon: [lat, lon]
      lat_lon: [12.34, 56.78]

      # metric (Celsius), imperial (Farenheit), or standard (Kelvin). Default is metric
      units: metric
      # If omitted, blank or false, show current weather
      forecast: true
      # Day offset (GMT time) for forecast (max 5, default 1)
      forecast_day: 0
      # Hour offset (GMT time) for forecast on selected day. One of 0, 3, 6, 9, 12, 15, 18, 21. default is 12
      # If selected time is more than 5 * 24 hours from present time, the latest available forecast will be shown
      forecast_hour: 3
      # Override the key used to display the app ID. This means if forecast is true, use weather_forecast, otherwise use weather_current
      id_key_override: [forecast, weather_forecast, weather_current]
  - app:
    name: temp
    duration: 30
    animate: false
    scope: quadrant
      #- app:
      #name: snap
      #animate: true
    # duration: 5
    #scope: panel
    #args:
    #file: every-third-row.json
    #path: snapshot_files/right
    #panel: right
  bottom-right:
  - app:
    name: noop1
    duration: 30
    # Keep the quadrant blank in this time slot. Used in conjunction with an app
    # in the top quadrant that fills the entire panel.
    display: false
  - app:
    name: fan
    duration: 30
    animate: false

      #- app:
      #name: noop2
      #display: false
      #duration: 30
  bottom-left:
  - app:
    name: noop1
    duration: 30
    display: false
  - app:
    name: mem-bat
    duration: 30
    animate: false
      #- app:
      #name: noop2
      #duration: 30
      #display: false

[MidnightJava]

Your config is fine, and I can't think of any way that a config could interfere with the display of the icons. I should clarify, however, that six rows high means that's the size of the array for each icon. However, not all those rows have lit pixels, depending on the icon. Most of them do, but clouds and clear are an exception. Clouds has only three rows with pixels turned on (and only five rows total vs six for all the others), and clear has five. All the others have six.

I suspect you're displaying the clouds icon when you see only three rows lit. You can see all the weather icons in patterns.py, starting at line 664. If you want to simulate any weather condition to see each icon rendering, look at time_weather_plugin.py line 155. Change weather[2].lower() to one of the key values of the icons dict in weather.py. Keep in mind that if you have a three-digit temp value, the bottom of the icon may be cut off. You can simulate a temp with fewer characters by changing temp in line 155 to a numeric string, like '1'.

[sjjh]

I can't think of any way that a config could interfere with the display of the icons

I was wondering, if maybe the panel option did not work and thus it is cut off after half.

This is how it looks for me.

[MidnightJava]

Yes, that's exactly as expected. Temp value does not pad with zeros, so with a single-digit non-negative temp, that's all there is to display. The cloud icon only has three rows. If you want to ensure it covers the whole panel, switch units to standard to get temp in Kelvin. As long as you're within the bounds of the solar system, I think you'll get a three-digit value. :)