Skip to content

[X64] [MihaZupan] Implement IEquatable on Uri #417

Description

@MihuBot

Job completed in 19 minutes.
dotnet/runtime#103511

Diffs

Found 267 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 40851066
Total bytes of diff: 40851208
Total bytes of delta: 142 (0.00 % of base)
Total relative delta: -0.76
    diff is a regression.
    relative diff is an improvement.


Total byte diff includes 1177 bytes from reconciling methods
	Base had    0 unique methods,        0 unique bytes
	Diff had    1 unique methods,     1177 unique bytes

Top file regressions (bytes):
          89 : System.Private.Uri.dasm (0.10 % of base)
          38 : System.Net.Mail.dasm (0.02 % of base)
          16 : System.Private.Xml.dasm (0.00 % of base)
          10 : System.IO.Packaging.dasm (0.01 % of base)
           4 : System.Net.Primitives.dasm (0.00 % of base)
           2 : System.ServiceModel.Syndication.dasm (0.00 % of base)

Top file improvements (bytes):
         -13 : System.Diagnostics.DiagnosticSource.dasm (-0.01 % of base)
          -4 : System.Net.Http.dasm (-0.00 % of base)

8 total files with Code Size differences (2 improved, 6 regressed), 250 unchanged.

Top method regressions (bytes):
        1177 (Infinity of base) : System.Private.Uri.dasm - System.Uri:Equals(System.Uri):ubyte:this (FullOpts) (0 base, 1 diff methods)
          38 (1.15 % of base) : System.Net.Mail.dasm - System.Net.Mail.SmtpClient:Send(System.Net.Mail.MailMessage):this (FullOpts)
           8 (0.72 % of base) : System.IO.Packaging.dasm - System.IO.Packaging.PackageRelationshipSelector:Select(System.IO.Packaging.Package):System.Collections.Generic.List`1[System.IO.Packaging.PackageRelationship]:this (FullOpts)
           4 (1.15 % of base) : System.Net.Http.dasm - System.Net.CredentialCacheKey:Equals(System.Net.CredentialCacheKey):ubyte:this (FullOpts)
           4 (1.15 % of base) : System.Net.Primitives.dasm - System.Net.CredentialCacheKey:Equals(System.Net.CredentialCacheKey):ubyte:this (FullOpts)
           4 (2.55 % of base) : System.Private.Xml.dasm - System.Xml.Schema.ChameleonKey:Equals(System.Object):ubyte:this (FullOpts)
           4 (3.25 % of base) : System.Private.Xml.dasm - System.Xml.Schema.Datatype_anyURI:Compare(System.Object,System.Object):int:this (FullOpts)
           4 (0.48 % of base) : System.Private.Xml.dasm - System.Xml.Schema.XmlSchemaSet:RemoveSchemaFromCaches(System.Xml.Schema.XmlSchema):this (FullOpts)
           4 (2.42 % of base) : System.Private.Xml.dasm - System.Xml.XmlTextReaderImpl:UriEqual(System.Uri,System.String,System.String,System.Xml.XmlResolver):ubyte (FullOpts)
           2 (0.35 % of base) : System.IO.Packaging.dasm - System.IO.Packaging.PackUriHelper:ResolvePartUri(System.Uri,System.Uri):System.Uri (FullOpts)
           2 (0.73 % of base) : System.Net.Http.dasm - System.Net.Http.HttpConnectionPoolManager+HttpConnectionKey:Equals(System.Net.Http.HttpConnectionPoolManager+HttpConnectionKey):ubyte:this (FullOpts)
           2 (0.58 % of base) : System.Net.Http.dasm - System.Net.Http.HttpConnectionPoolManager+HttpConnectionKey:Equals(System.Object):ubyte:this (FullOpts)
           2 (1.56 % of base) : System.ServiceModel.Syndication.dasm - System.ServiceModel.Syndication.FeedUtils:GetBaseUriToWrite(System.Uri,System.Uri):System.Uri (FullOpts)
           2 (4.76 % of base) : System.Private.Uri.dasm - System.Uri:op_Equality(System.Uri,System.Uri):ubyte (FullOpts)
           2 (4.00 % of base) : System.Private.Uri.dasm - System.Uri:op_Inequality(System.Uri,System.Uri):ubyte (FullOpts)

Top method improvements (bytes):
       -1092 (-80.65 % of base) : System.Private.Uri.dasm - System.Uri:Equals(System.Object):ubyte:this (FullOpts)
         -13 (-8.23 % of base) : System.Diagnostics.DiagnosticSource.dasm - System.Diagnostics.Metrics.CounterAggregator:Update(double):this (FullOpts)
         -12 (-11.65 % of base) : System.Net.Http.dasm - System.Net.Http.HttpEnvironmentProxyCredentials:GetCredential(System.Uri,System.String):System.Net.NetworkCredential:this (FullOpts)

Top method regressions (percentages):
        1177 (Infinity of base) : System.Private.Uri.dasm - System.Uri:Equals(System.Uri):ubyte:this (FullOpts) (0 base, 1 diff methods)
           2 (4.76 % of base) : System.Private.Uri.dasm - System.Uri:op_Equality(System.Uri,System.Uri):ubyte (FullOpts)
           2 (4.00 % of base) : System.Private.Uri.dasm - System.Uri:op_Inequality(System.Uri,System.Uri):ubyte (FullOpts)
           4 (3.25 % of base) : System.Private.Xml.dasm - System.Xml.Schema.Datatype_anyURI:Compare(System.Object,System.Object):int:this (FullOpts)
           4 (2.55 % of base) : System.Private.Xml.dasm - System.Xml.Schema.ChameleonKey:Equals(System.Object):ubyte:this (FullOpts)
           4 (2.42 % of base) : System.Private.Xml.dasm - System.Xml.XmlTextReaderImpl:UriEqual(System.Uri,System.String,System.String,System.Xml.XmlResolver):ubyte (FullOpts)
           2 (1.56 % of base) : System.ServiceModel.Syndication.dasm - System.ServiceModel.Syndication.FeedUtils:GetBaseUriToWrite(System.Uri,System.Uri):System.Uri (FullOpts)
           4 (1.15 % of base) : System.Net.Http.dasm - System.Net.CredentialCacheKey:Equals(System.Net.CredentialCacheKey):ubyte:this (FullOpts)
           4 (1.15 % of base) : System.Net.Primitives.dasm - System.Net.CredentialCacheKey:Equals(System.Net.CredentialCacheKey):ubyte:this (FullOpts)
          38 (1.15 % of base) : System.Net.Mail.dasm - System.Net.Mail.SmtpClient:Send(System.Net.Mail.MailMessage):this (FullOpts)
           2 (0.73 % of base) : System.Net.Http.dasm - System.Net.Http.HttpConnectionPoolManager+HttpConnectionKey:Equals(System.Net.Http.HttpConnectionPoolManager+HttpConnectionKey):ubyte:this (FullOpts)
           8 (0.72 % of base) : System.IO.Packaging.dasm - System.IO.Packaging.PackageRelationshipSelector:Select(System.IO.Packaging.Package):System.Collections.Generic.List`1[System.IO.Packaging.PackageRelationship]:this (FullOpts)
           2 (0.58 % of base) : System.Net.Http.dasm - System.Net.Http.HttpConnectionPoolManager+HttpConnectionKey:Equals(System.Object):ubyte:this (FullOpts)
           4 (0.48 % of base) : System.Private.Xml.dasm - System.Xml.Schema.XmlSchemaSet:RemoveSchemaFromCaches(System.Xml.Schema.XmlSchema):this (FullOpts)
           2 (0.35 % of base) : System.IO.Packaging.dasm - System.IO.Packaging.PackUriHelper:ResolvePartUri(System.Uri,System.Uri):System.Uri (FullOpts)

Top method improvements (percentages):
       -1092 (-80.65 % of base) : System.Private.Uri.dasm - System.Uri:Equals(System.Object):ubyte:this (FullOpts)
         -12 (-11.65 % of base) : System.Net.Http.dasm - System.Net.Http.HttpEnvironmentProxyCredentials:GetCredential(System.Uri,System.String):System.Net.NetworkCredential:this (FullOpts)
         -13 (-8.23 % of base) : System.Diagnostics.DiagnosticSource.dasm - System.Diagnostics.Metrics.CounterAggregator:Update(double):this (FullOpts)

18 total methods with Code Size differences (3 improved, 15 regressed), 252029 unchanged.

--------------------------------------------------------------------------------

Artifacts:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions