Skip to content

Update threshold.py - #155

Merged
ANRudrapatna merged 1 commit into
mainfrom
ANRudrapatna-patch-2
Sep 14, 2026
Merged

ANRudrapatna merged 1 commit into
mainfrom
ANRudrapatna-patch-2

Conversation

@ANRudrapatna

@ANRudrapatna ANRudrapatna commented Nov 14, 2025

Copy link
Copy Markdown
Collaborator

Issue:

  • maxatac predict expects the following column names in a cutoff file:

    • 'Monotonic_Avg_Precision', 'Monotonic_Avg_Recall', 'Standard_Thresh', 'Monotonic_Avg_log2FC', 'Avg_F1'.
  • However, maxatac threshold outputs a file with the following column names:

    • 'Monotonic_Precision', 'Monotonic_Recall', 'Threshold', 'Monotonic_log2FC', 'Monotonic_F1'.
  • When these columns are not available, maxatac predict will not output a BED file of TFBS predictions, even when a cutoff file and type are specified by the user.

Fix:

  • I changed the column names in line 143 to correspond to the expected column names for maxatac predict.

I tested this change to ensure it works with v1.0.6 of maxATAC. A BED file of predictions is now outputted when a cutoff file and type are specified by the user.

@ANRudrapatna
ANRudrapatna merged commit b8faf59 into main Sep 14, 2026
@ANRudrapatna
ANRudrapatna deleted the ANRudrapatna-patch-2 branch September 14, 2026 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant