Make the comparison families consistent camelCase (tempEq/everEq/alwaysEq)#19
Open
estebanzimanyi wants to merge 1 commit into
Open
Conversation
The temporal/ever/always comparison operators take a one-letter prefix — t (temporal), e (ever), a (always) — over the spelled-out temp/ever/always, matching the operator-family abbreviation the bindings already use (eIntersects is the ever- form) and the MEOS C prefixes (teq_/eeq_/aeq_). So: #= #<> #< #<= #> #>= -> tEq tNe tLt tLe tGt tGe ?= ?<> ?< ?<= ?> ?>= -> eEq eNe eLt eLe eGt eGe %= %<> %< %<= %> %>= -> aEq aNe aLt aLe aGt aGe Also spell the distance bare name tDistance (camelCase), matching the canonical tgeo @sqlfn spelling, so the portable dialect and the catalog agree on one case-sensitive name (a binding engine that folds case otherwise shadows one spelling with the other).
6aaec3b to
4b895d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The three comparison families now share one camelCase shape
<prefix>{Eq,Ne,Lt,Le,Gt,Ge}: temporal#=→tempEq…, ever?=→everEq…, always%=→alwaysEq….Previously
#=was lowercaseteq/tne…, and ever/always were underalreadyCanonical(left as snakeever_*/always_*) — i.e. no portable bare name at all, violating the contract's own 100%-parity goal and leaving the th3 prefilter predicate without a portable name. Pairs with MobilityDB#1075's generator (OP_TO_NAME) so every binding regenerates identical names.