docs(rfc): add RFC 0043, GQ logic tests

[azimafroozeh]

What & why

RFC 0043 makes query-behavior tests one self-contained text file per case (.gqt): a header (issue anchor, red_on: provenance), a .pg schema, JSONL seed rows, then steps (--- query / --- mutate / --- restart, loopable), each with params and an expected outcome (rows, affected counts, or an error substring). One test target, crates/omnigraph/tests/gq_logic_tests.rs, runs each case against a fresh temporary store through public engine surfaces only; no second toolchain. An enforcement ladder makes the medium stick: AGENTS.md contract sentences, a CI gate holding issue-closing fix PRs to a matching regression, and a no-repro waiver label.

Why now: review of the #563 fix surfaced a pure input-to-output defect (aggregates computed over the capped BM25 scan window) a twenty-row logic test case would have caught before review. The format adopts the sqllogictest lineage (SQLite, DuckDB, DataFusion) at its mature state and omits its documented mistakes (result hashing, type strings, bare any-error expectations).

Backing issue / RFC

• Is an RFC PR: docs/rfcs/0043-gq-logic-tests.md

Checklist

• Change is focused (one RFC plus its registry row)
• Tests added/updated for behavior changes (N/A: proposal only)
• Public docs updated if user-facing surface changed (the RFC and its registry row are the docs; no engine surface changes)
• Reviewed against docs/dev/invariants.md — no Hard Invariant weakened, no deny-list item hit

Local verification

• python3 scripts/check-docs.py — green (front matter, registry row, links)
• cargo test --workspace — not run: docs-only diff

Notes for reviewers

• Number 0043: open PRs hold 0040 (rfc: add RFC 0040, the system column namespace #546) and 0042 (rfc: add RFC 0046, read-only index status #552); next-available moves to 0044. If rfc: add RFC 0046, read-only index status #552 merges first, docs/rfcs/README.md conflicts on the index table; keep both new rows in number order, 0044 stands.
• v1 takes the full corpus role (feature cases, mutate and restart steps, loops), argued in Alternatives. Run-twice traversal-mode verification is deferred past perf(traversal): adaptive mode switch, limit pushdown, persisted CSR #544 (Compatibility); proptest_equivalence.rs keeps owning equivalence.
• Rollout after acceptance: two implementation PRs — harness plus first corpus, then the enforcement gate.

Greptile Summary

This documentation-only PR proposes RFC 0045, defining a self-contained .gqt format and an enforcement model for query-behavior regression tests.

• Specifies schema, seed, query, mutation, restart, loop, comparison, and bless semantics.
• Defines CI execution, fix-regression gating, waiver handling, and heavy-reproduction tiers.
• Registers RFC 0045 in the RFC index.

Confidence Score: 5/5

The PR appears safe to merge because no blocking failure remains.

No blocking failure remains.

Important Files Changed

Filename	Overview
docs/rfcs/0045-gq-logic-tests.md	Adds the RFC describing the .gqt format, runner semantics, CI enforcement, compatibility boundaries, evidence plan, and rollout.
docs/rfcs/README.md	Adds the RFC 0045 registry entry with frontmatter-consistent metadata.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Case[.gqt case] --> Parse[Fail-closed parser]
  Parse --> Init[Fresh temporary store]
  Init --> Seed[Load JSONL seed]
  Seed --> Index[Ensure required indexes]
  Index --> Steps[Run query / mutate / restart steps]
  Steps --> Compare[Normalize and compare outcomes]
  Compare --> Result[Report case result]
  PR[Issue-closing PR] --> Gate[Fix Regression Gate]
  Gate -->|matching regression| CI[GQ Logic Tests]
  Gate -->|no-repro label| Waiver[Maintainer waiver]
  CI --> Result

Loading

_{Reviews (5): Last reviewed commit: "docs(rfc): address review: gate guarante..." | Re-trigger Greptile}

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

[aaltshuler]

Three RFC-level comments: the regression-gate guarantee, ranked ordering semantics, and bounded runner concurrency.