Keep first-run init warnings non-actionable - #147
Merged
Conversation
`init` was treating every doctor warning as a failure, including the normal state of a freshly initialized repository with no remote. The warning stays visible, but only checks that need user action now drive its summary and exit code. Query help and the query skill now name Git's one-path rename-following limit and the CLI diagnostic that appears for multiple paths. Ruled-out: treating every doctor warn as actionable | no remote is expected before a repository begins sharing records, while configured remote failures still need action Ruled-out: promising rename following for several paths | git log --follow accepts one pathspec and the CLI already reports that limit Limit: the generated dist artifacts are rebuilt from TypeScript source Warn: a configured but unreachable remote remains an actionable warning and exits 1 Blast: module Undo: easy Certainty: firm Record-Id: r-init107
CommitLore — record lintTrailers: clean — 1 commit in Active constraints for the paths this PR touchesLimits (37)
Ruled out (89)
Warnings (47)
Trailer violations fail this check. Active constraints are informational — they are what the repository already decided, not a verdict on this PR. |
MongLong0214
marked this pull request as ready for review
July 28, 2026 22:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #107
Closes #69
What changed
commitlore initexits 0 and reports a clean four-step run.Verification
init: warning and skipped checks remain visible; exits 0.npx vitest run— 40 files passed; 1,413 tests passed; 1 skipped.npx tsc -p tsconfig.json --noEmitnpx tsc -p bench/tsconfig.json --noEmitf485f07381970a3e5fcf8f7647611ab184b66132.No wall-clock benchmark was run.