Land the Gate A acceptance matrix and its two missing tickets - #214
Merged
Conversation
ADR-0020, ADR-0021, ADR-0022 and PRD-F9 all cite a "CTO acceptance matrix" (rows P0-1 through P0-8, P1-5) as an authority they depend on or are accepted against. No such file was ever committed. An authority reference that points at nothing is exactly what A-001's own acceptance criterion (from the source review these documents trace to) rules out. docs/GATE-A-ACCEPTANCE.md reconstructs each row from where its label was actually cited, not from a recovered original — the file states this and records the one grep that would disprove it (git log -p --all for any prior text). Two rows had no ticket: P0-4 (the P0-3 architecture proven end-to-end, not only per-ticket unit AC) had no closing ticket. T-1023 adds one: real CLI/MCP invocation, real Git commit, real linked worktree, not mocked modules. P0-7 has no prior citation anywhere in this repository. It is not a recovered row; it is named from an operational gap found by reading PRD-F9's 14 requirements end to end: none of them mention removing a pending-transaction file, and T-1002's prepare step writes one on every capture attempt including ones that verify empty. Nothing ever deletes it. T-1019 adds recovery and GC. The numbering gap (T-1018 to T-1020, P0-6 to P0-8) is circumstantial and is labelled as such in the document — it is not evidence of a lost definition. Separately, T-1007, T-1008, T-1009 and T-1020 all edit src/mcp/server.ts. T-1009 already depended on T-1007 and T-1008, but T-1007/T-1008 had no ordering between each other, and T-1020 depended only on the already-accepted ADR-0020 — so all four were eligible to start in parallel against the same file. Each ticket now states the merge order explicitly. Ruled-out: rewriting ADR-0020/0021/0022 or the existing #193-213 issue bodies | they already meet or exceed the source review's own requirements (exact ownership, forbidden scope, RED/GREEN, AC-to-test, four-tier verification, evidence invalidation, stop conditions); rewriting working documents to match a stale review would be pure churn Ruled-out: inventing content for a hypothetical P0-7 original definition | none exists in history (verified); asserting one would be the exact failure this document exists to prevent Limit: nothing enforces the src/mcp/server.ts merge-sequencing rule automatically — it is a process constraint the next PR author has to read and follow Blast: local Undo: easy Certainty: firm Record-Id: r-gateaacc
CommitLore — record lintTrailers: clean — 1 commit in Active constraints for the paths this PR touchesLimits (3)
Ruled out (8)
Warnings (4)
Trailer violations fail this check. Active constraints are informational — they are what the repository already decided, not a verdict on this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADR-0020/0021/0022 and PRD-F9 cite a "CTO acceptance matrix" (P0-1..P0-8, P1-5) as authority. It never existed as a file.
docs/GATE-A-ACCEPTANCE.mdreconstructs each row from its actual citation site — not from a recovered original — and states that distinction explicitly, including the one grep (git log -p --all) that would disprove it. I ran that grep before committing; nothing was missed.Two rows had no closing ticket:
Also: T-1007/T-1008/T-1009/T-1020 all edit
src/mcp/server.tsand had no complete ordering between them (T-1009 depended on two of the three; T-1020 depended on neither). Each now states the merge order.Not touched: ADR-0020/0021/0022, PRD-F9/F10, or the #193-213 issue bodies. They already meet the source review's own bar (exact ownership, forbidden scope, RED/GREEN, AC-to-test, four-tier verification) — rewriting them would be churn, not correction.
npx tsc -p tsconfig.json --noEmitexits 0.