fix: lint full promotion range on dev push (#186) - #252
Merged
Conversation
The demo-lint workflow only triggered on pull_request events, so it linted only a PR's own commits. Two commits duplicating a Record-Id from separate PRs appeared together only in the full origin/main..dev range, which nothing checked until a promotion PR was opened. The r-readme729 collision sat green for a day because of this blind spot. Add a promotion-range-lint job that fires on push to dev and validates the full origin/main..HEAD range. The existing PR lint job is unchanged; it still validates only the PR's own commits via the action's base-ref logic. Record-Id: r-rangelint186 Blast: system Undo: easy Certainty: firm Evidence: .github/workflows/demo-lint.yml
CommitLore — record lintTrailers: clean — 1 commit in Active constraints for the paths this PR touchesLimits (1)
Ruled out (3)
Warnings (2)
Trailer violations fail this check. Active constraints are informational — they are what the repository already decided, not a verdict on this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #186
Problem
The demo-lint workflow only triggered on
pull_requestevents, so it linted only a PR's own commits. Two commits that duplicate a Record-Id (like the knownr-readme729collision between051fee9anda2c657a) appear together only in the fullorigin/main..devrange — which nothing checked until a promotion PR was opened.Fix
Add a
promotion-range-lintjob todemo-lint.ymlthat fires on push todevand validatesorigin/main..HEAD. The existing PR lint job is unchanged.Backlog check
Running
node dist/commitlore.mjs validate --range origin/main..origin/dev --jsonat dev head6b4b725returned 0 violations, 0 secrets — the first push will not be red.Verification
devfrom push branches fails; changing range fromorigin/main..HEADfails