Sell what the product does, not a verdict it never makes - #347
Merged
Conversation
"Stop re-reviewing the same bad idea" claimed something this tool does not do. It does not decide whether an idea is bad. It decides whether a decision still applies -- and an approach rejected last quarter can be the right one now that the constraint behind the rejection is gone. That distinction is the product; the headline erased it. Worse, it read as a promise about `guard`, which this project measures at precision 44.8% and recall 22.0% and labels an experimental advisory whose empty result is not a safety verdict. A headline leaning on the least-proven part, in a repository whose strongest asset is that it prints its own weak numbers next to the feature they belong to. It was also generic. A review bot, an ADR search, an architecture linter could all have carried that line, which means it identified no mechanism at all. The replacement names what actually crosses the boundary. Code survives a session; the constraints, the rejected alternatives, the warnings and the verification gaps do not, and `inherit` is the one word that covers sessions, agents and people at once. It claims preservation and delivery -- both of which are built and tested -- and claims no judgement about any proposal. The old line keeps a job. As pain copy above the before/after scene it is accurate, because that scene is a case where the decision genuinely still stands. It was only wrong as the thing the product is. Record-Id: r-heroinherit Limit: a headline that implies detection commits the product to guard's numbers, and guard is an advisory measured at 22% recall Ruled-out: Keeping "Stop re-reviewing the same bad idea" as the hero | it names a verdict on ideas rather than a lifecycle on decisions, and any review tool could carry it Ruled-out: "Never let agents make the same mistake twice" | guard cannot support a never, and the sentence sells detection this product does not perform Ruled-out: Leading with "decision authority" alone | precise in the architecture sections, and not a phrase a first-time reader converts on Certainty: firm Blast: local Undo: easy Verified: readme, readme-order, readme-numbers, compatibility-matrix, install-script and manifest suites pass at 116 across four languages; check-readme-numbers exits 0; typecheck clean; the install commands and the compatibility pointer survive the rewrite in all four files Unverified: whether the line converts, which is not measurable here
CommitLore — record lintTrailers: clean — 1 commit in Active constraints for the paths this PR touchesLimits (38)
Ruled out (85)
Warnings (24)
Trailer violations fail this check. Active constraints are informational — they are what the repository already decided, not a verdict on this PR. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A second conversion review rejected the hero the first one produced. It was right, and the reason is a claim-accuracy problem rather than a taste one.
Why
Stop re-reviewing the same bad ideahad to goIt claims a judgement this tool never makes. CommitLore does not decide whether an idea is bad. It decides whether a decision still applies — and an approach rejected last quarter can be correct now that the constraint behind the rejection is gone. That distinction is the product, and the headline erased it.
It read as a promise about
guard. This project measures guard at precision 44.8%, recall 22.0%, labels it an experimental advisory, and states that an empty result is not a safety verdict. A headline implying detection leans the whole product on its least-proven part — in a repository whose strongest asset is that it prints those numbers next to the feature they belong to.It was generic. A PR review bot, an ADR search, or an architecture linter could all carry that line. It identified no mechanism.
The replacement
inheritcovers sessions, agents and people in one word. The claim is preservation and delivery — both built, both tested — and no verdict about any proposal.Supporting line names the differentiator directly: a decision that was later superseded or expired does not reach the agent as if it still stood. That is what similarity search cannot do, and it is measured.
The old line kept a job
It is accurate as pain copy above the before/after scene, because that scene is a case where the decision genuinely still stands. It was only wrong as the thing the product is.
Verification
check-readme-numbers.mjsexit 0;npm run typecheckclean