Make the hero image say what the heading below it says - #384
Merged
Conversation
The first screen carried three different taglines. The image said "Git remembers what changed. CommitLore remembers why.", the heading under it said "Your agents inherit the code. Make them inherit the judgment.", and the alt text said a coding agent must not revive a decision the repository already reversed. The image was left behind by a positioning change that moved the heading twice and never reopened the SVG. The rebuild keeps what was already right: the split composition, the warm paper palette, and real material from this repository rather than decoration. What changes is the headline, and what the card on the right shows. It used to show one ruled-out alternative. It now shows an active record beside a superseded one that is withheld, because the lifecycle filter is the part of this product no comparable tool has, and the old card demonstrated the part several of them do. The demo SVG gained a `<title>` and a `<desc>`, and the generator gained the reason. `aria-label` on the root serves the README's `img` embed and nothing else; a reader who opens the file directly had no name for it. Regenerated rather than hand-edited, since the file says not to edit it by hand. The bottom caption was clipped on the first attempt -- it read "hook con" at the canvas edge -- which a rendered preview caught and a well-formedness check would not have. Shortened until it fits. Record-Id: r-heroconsist Limit: the card text is 19-20 units, so at a 360-pixel mobile render it falls below the legible threshold; the headline and the alt text carry the message there, and the same content is in the Markdown below, but the card itself is decoration at that width Ruled-out: Converting the animated demo to a GIF | the skill that prompted this review states GitHub does not play animation inside SVG, and GitHub was observed serving this file byte-identical with all five SMIL elements intact, so a GIF would cost the text layer and the file size for nothing Ruled-out: Turning the delivery table into a chart | tables belong in Markdown where they stay selectable and diffable, and the numbers would have left the text layer Certainty: firm Blast: local Undo: easy Verified: rendered at 1200 and inspected -- nothing clipped, active and superseded rows both legible; both SVGs parse; readme, readme-order, readme-numbers, readme-positioning, compatibility-matrix, demo and manifest pass at 114; check-readme-numbers.mjs exit 0 with the BENCH block byte-identical; spec/verify.sh OK at 26 fixtures; the skill's own audit_readme.py reports no issues Unverified: how the hero reads in GitHub's dark theme -- the palette is a fixed light paper and was not re-checked against a dark background
CommitLore — record lintTrailers: clean — 1 commit in Active constraints for the paths this PR touchesLimits (2)
Ruled out (6)
Warnings (1)
Trailer violations fail this check. Active constraints are informational — they are what the repository already decided, not a verdict on this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applied the
beautify-github-readmeskill in README mode, then scoped to the smallest change that produced a real improvement — which is what the skill asks for.The finding
The first screen carried three different taglines:
##heading directly belowThe image was left behind by a positioning change that moved the heading twice and never reopened the SVG.
Changed
hero.svgrebuilt. Keeps the split composition, the warm paper palette, and real material from this repository. The headline is now the current positioning. The right-hand card used to show one ruled-out alternative; it now shows an active record beside a superseded one that is withheld — the lifecycle filter is the part of this product no comparable tool has, and the old card demonstrated the part several of them do.commitlore-demo.svggained<title>and<desc>, via the generator (scripts/record-demo.mjs), not by hand — the file says not to edit it by hand.aria-labelon the root served the README'simgembed and nothing else.Two things I checked rather than assumed
<img src>byte-identical, all five SMIL<set>elements intact. The animation works. Converting to GIF would have cost the text layer, accessibility and file size for nothing — so it was not done.hook con. A well-formedness check would not have found it. Shortened until it fits.Not done, deliberately
The delivery table stays Markdown. Tables belong in the text layer where they stay selectable and diffable, and the skill says the same.
Verified
audit_readme.py<title>, now cleanreadme,readme-order,readme-numbers,readme-positioning,compatibility-matrix,demo,manifestcheck-readme-numbers.mjsspec/verify.shKnown limit, recorded in the commit: the card text is 19–20 units, so at a 360px mobile render it falls below the legible threshold. The headline and alt text carry the message there and the same content is in the Markdown below, but the card is decoration at that width.