Record the installer divergence, and why the dead block stays - #699
Merged
Conversation
v1.0.1 shipped and looking at what its fixes touched turned up two more: the hook pinned a release, and the two platform installers do different things. The second is the one worth writing down. install.sh carried host wiring it never called, install.ps1 both delegates and wires, and Windows does every host twice. Deleting the POSIX copy looks obvious and is wrong until each row is confirmed -- the Codex plugin gap proves the two sides are not equivalent, so removing one on the assumption that they are would delete a step nothing else performs. The trap section is the part that generalises. Two assertions passed for years while the shell wired nothing: one checked that config paths were present in install.sh, the other that both installers said the same sentences. Presence, not reachability; parity between a live script and a dead block. Three issues were invisible underneath them. Limit: an assertion that names a file does not assert the file does anything Blast: system Undo: easy Certainty: firm Provenance: authored Record-Id: r-post101
CommitLore — record lintTrailers: clean — 2 commits in Trailer violations fail this check. Active constraints are informational — they are what the repository already decided, not a verdict on this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation only. Continues
docs/handoff/20260815-after-v1.mdpast v1.0.1.Two things came out of looking at what v1.0.1's fixes touched:
validating commits with the build they were installed from. Three on the first
machine to upgrade, this one among them, through two releases. Fixed in Give the hook a path that outlives the release it was installed from #696;
the obvious repair was tried in Record a launcher the hook can keep across upgrades #694 and is wrong, recorded so nobody repeats
it.
install.ps1installs the Codex plugin andinstall.shnever did.Deleting the shell's dead host block is what revealed it.
The part worth keeping
Two assertions passed for years while the shell wired nothing:
Presence, not reachability. Parity between a live script and a dead block. #689,
#697 and half of #660 were invisible underneath them.
An assertion that names a file is not an assertion that the file does
anything.
And why #691 stays open
install.sh's 291 dead lines look deletable.install.ps1's wiring is not theirdead twin — it delegates and wires, so Windows does every host twice. The Codex
gap proves the two sides are not equivalent, so the order is fixed: confirm the
enumeration performs each row, remove the duplicate, then the dead block. The
reverse deletes a step nothing else performs, on a platform the author cannot
run.
No code, no artifact change.