Say a decision was lost only when one was (#710) - #711
Merged
Conversation
The stale-pending warning appended its explanation to both branches. A draft that never reached staging holds no record, so a repository with four empty prepared captures was told four decisions were never written to the history — and `pending ls`, the fix offered beside it, then shows RECORDS 0 and nothing to recover. The count was already right. `lost` has distinguished staged losses from earlier drafts since #458; only the sentence explaining the count was borrowed from the branch above it. The guard for this existed and did not assert it. `warns without claiming a record was lost when nothing reached staged` checked for the absence of the *other* branch's wording and let the stronger claim through, while the neighbouring consumed case already used `never written to the history` as the loss claim. That assertion is now the one the test's name promises. Limit: the wording is checked, not the severity — an abandoned draft still warns Ruled-out: drop the warning for the non-staged case | a stale draft is still worth surfacing, and #584 already showed that going quiet on a healthy-looking path is how this check loses its meaning Blast: module Undo: easy Certainty: firm Record-Id: r-pend710 Provenance: authored Verified: the new assertion fails against the unfixed source (expected '1 capture(s) can no longer apply — th…' not to match /never written to the history/) and passes after; npx tsc --noEmit clean; 29 cases pass across doctor-pending-backlog, pending-command and capture-pipeline-e2e; npm run build:canonical then artifact:verify -> de9222c7187eb818ab20cfea63fa3e918e56f7eca1dc9fff654cae4bf39c0daf CommitLore-Version: 2.0.0
CommitLore — record lintTrailers: clean — 1 commit in Trailer violations fail this check. Active constraints are informational — they are what the repository already decided, not a verdict on this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #710.
doctortold this repository four decisions were never written to the history. The four captures it meant hold zero records and never reached staging — nothing was drafted, so nothing was dropped.The count was never wrong.
losthas separated staged losses from earlier drafts since #458; the explanation appended after it was written for the staged branch and emitted for both.The guard that should have caught it
warns without claiming a record was lost when nothing reached staged— the test is named for exactly this property and asserted the absence of the other branch's wording:The consumed case two tests below already uses
never written to the historyas the loss claim, so the string was established as the thing to check. This case just did not check it. That assertion is now what the name promises, and it fails against the unfixed source:What the non-staged branch says now
That is the file's own existing explanation of staleness, from the comment above
stranded.Not changed
The severity. An abandoned draft still warns — #584 showed that going quiet on a path that looks healthy is how this check loses its meaning, and that judgement is separate from the wording.
Verified
npx tsc --noEmitcleandoctor-pending-backlog,pending-command,capture-pipeline-e2enpm run build:canonicalthennpm run artifact:verify→de9222c7187eb818ab20cfea63fa3e918e56f7eca1dc9fff654cae4bf39c0daf