Correct what 1.1.1 says about Hermes: it works - #726
Merged
Conversation
The 1.1.1 entry says Hermes still fails for an unnamed cause. It does not. The last real Windows run on #720 reports `outcome: "installed"`, `healthy: true`, `Hermes setup verified`, alongside Codex and Gemini CLI — three of the four detected hosts, not two. The cause was the trailing backslash. `--data-root` ends with one on Windows, so it was the argument the closing quote consumed and `--verify` was the argument absorbed after it. Repairing that quoting is what made the step work; the reviewer who found it predicted the opposite failure -- a `verified` printed without verification -- and the real behaviour was a refusal instead. Both follow from the same broken argv. Why this was wrong for several hours: an earlier run in that pull request did report `Hermes setup failed`, I quoted it, and I kept quoting it while a later run in the same thread said otherwise. The deciding artifact was already posted and I did not re-read it before writing the note. It reached a published release body, which is the surface quoted longest. `claude-code` remains `notDetected` with its config present, because detection for it is executable-based while the JSON hosts fall back to a config directory. That asymmetry is real and stays open on #716; it is not the Hermes question and should not inherit its answer. Limit: the release body for v1.1.1 was already corrected and republished; this brings the in-repository record to match Ruled-out: leave it and correct it in 1.1.2 | a note that misreports which hosts work is read by everyone deciding whether to upgrade, and it was wrong in the direction of underselling a fix that landed Blast: local Undo: easy Certainty: firm Record-Id: r-clogherm111 Provenance: authored Verified: the enumeration JSON in the final #720 run -- codex custom-preserved healthy, gemini-cli custom-preserved healthy, hermes installed healthy "Hermes setup verified", cursor failed naming its path -- read from the pull request rather than from any summary of it, and matching the inherited record r-winargv716 now on 7bf5b82 CommitLore-Version: 2.0.0
CommitLore — record lintTrailers: clean — 1 commit in Trailer violations fail this check. Active constraints are informational — they are what the repository already decided, not a verdict on this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 1.1.1 entry says Hermes still fails for an unnamed cause. It does not — the last real Windows run on #720 reports
installed,healthy,Hermes setup verified.The cause was the trailing backslash:
--data-rootends with one on Windows, so it was the argument whose closing quote was consumed and--verifywas what got absorbed after it. Repairing the quoting is what made the step work.An earlier run in that PR did report
Hermes setup failed. I quoted it and kept quoting it while a later run in the same thread said otherwise — the deciding artifact was already posted and I did not re-read it before writing the note. It reached the published release body, which has been corrected and republished.claude-codestaysnotDetectedwith its config present, because its detection is executable-based while the JSON hosts fall back to a config directory. That asymmetry is real, stays open on #716, and does not inherit the Hermes answer.