Let installer fixtures express executable modes (#716) - #733
Merged
Conversation
The POSIX resolver regression was locked with a hand-built pair while the shared installer wrapper always chmodded every fixture 0755. That left the main fixture API unable to construct the state the regression depends on, so a future test using the helper could still produce a misleading green. Move the shadow assertion beside the shared wrapper and let the wrapper take an explicit mode. Its default remains 0755, while the regression now asks the ordinary fixture path for 0644 and 0755 files. Limit: test fixtures only; production resolution and spawning are unchanged Ruled-out: keep the hand-built shadow pair | it preserves the helper blind spot the owner identified Blast: local Undo: easy Certainty: firm Record-Id: r-fixture716 Provenance: authored Verified: tsc --noEmit clean; Windows installer suites 29 passed with the one POSIX-only executable-mode case skipped CommitLore-Version: 2.0.0
CommitLore — record lintTrailers: clean — 5 commits in Trailer violations fail this check. Active constraints are informational — they are what the repository already decided, not a verdict on this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relays #725 so it can merge. The change and its authorship are @plutoparty1's; the only thing added here is a merge from
main.#725 sits on a fork, and after #730 landed,
maincarries a change to.github/workflows/demo-preserve.yml. Branch protection requires up-to-date before merge, and every route this token has to update a fork branch is refused:That is GitHub protecting workflow files from a token that was not granted the scope — correct behaviour, and not something to route around. Pushing the same branch to this repository is allowed, so it goes through here instead.
The change
wrapper()intest/installer-hosts.test.tshard-codedchmodSync(path, 0o755), so no fixture in that suite could be non-executable — meaning no defect involving executability could be caught there at all. The missingX_OKin #720 was the instance that happened to land, not the last one that could.It now takes a mode, and the mode-0644 shadow assertion moves beside the helper instead of being hand-built in another file. The duplicate is removed.
Verification
artifact:verify→14ff6168…, unchanged by the merge: the canonical source inputs arepackage-lock.json,package.json,tsconfig.jsonandsrc, and this touches onlytest/. No rebuild was required.#725 will be closed pointing here once this merges.