Two lines the register pass could not have seen - #759
Merged
Conversation
`#753` converged README.ko.md on 한다체 with six exceptions that follow one rule: address the reader and it stays polite, describe the product and it does not. Two lines break it, and neither was in that branch's diff -- `#751` wrote them, replacing the protocol section with a pointer, and the two branches never saw each other. Both describe where a document is. Nobody is being addressed, so both take the plain form the paragraphs around them use. The review that found it counted fourteen polite lines; my own count said twenty-five and was wrong. `아니다` contains `니다`, so a pattern matching the syllable alone reports every plain-form negation in the file as polite -- and this document has many, because refusing an overclaim is what it does. The precise pattern gives fourteen, all six documented exceptions plus the hero paragraph and the two heading lines the contents links anchor to. Limit: nothing checks this -- the rule lives in the PR that established it and in a comment, and the next section written in the wrong register will land the same way these did, from a branch that never touched the file the rule was recorded on Blast: local Undo: easy Certainty: firm Record-Id: r-koregdrift Provenance: authored Verified: after the change the precise pattern returns fourteen lines and every one is a documented exception -- hero 17-30, contents 46-47, the CTA at 105, the read-before-installing line at 192, and the two headings at 277 and 290; the conformance suite and the numbers gate both pass CommitLore-Version: 2.0.0
CommitLore — record lintTrailers: clean — 1 commit in Trailer violations fail this check. Active constraints are informational — they are what the repository already decided, not a verdict on this PR. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#753 converged
README.ko.mdon 한다체 with six exceptions following one rule: address the reader and it stays polite, describe the product and it does not.Two lines break it, and neither was in that branch's diff. #751 wrote them — replacing the protocol section with a pointer — and the two branches never saw each other.
Both describe where a document is. Nobody is addressed, so both take the plain form the surrounding paragraphs use.
My own count was wrong, and the reason is worth recording
The review counted fourteen polite lines. I counted twenty-five.
아니다contains니다. A pattern matching that syllable alone reports every plain-form negation as polite — and this document has many, because refusing an overclaim is what it does:The precise pattern gives fourteen, and all fourteen are documented exceptions:
Limit
Nothing checks this. The rule lives in the PR that established it and in a comment. The next section written in the wrong register will land the same way these did — from a branch that never touched the file the rule was recorded on.