Conversation
- Add PreferTextSubtitles and PreferExternalSubtitles properties to MoonfinSettingsProfile in Jellyfin and Emby plugins - Add UI controls to User Defaults section in configPage.html for Jellyfin and Emby, and wire load/save in moonfin.js - Add SubtitleSelectionProfileTests validating serialization, deserialization, and field retention
Build SuccessfulBoth plugins compiled against .NET 8, and both test suites passed.
|
9 of 25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Adds
preferTextSubtitlesandpreferExternalSubtitlesboolean settings to the user settings profile schema and default profile configuration, allowing client preferences for prioritizing text-based and external subtitle streams to persist and synchronize across devices.Related Issues
Link related issues or tickets separated by commas.
Type of Change
Area
Changes Made
List the key changes included in this PR.
PreferTextSubtitlesandPreferExternalSubtitlesnullable boolean properties to UserSettingsProfile.cs.false) to PluginConfiguration.cs.Client Impact
Does this need matching changes in a client repo (Core, Smart-TV, Roku)?
preferTextSubtitles(boolean)preferExternalSubtitles(boolean)Compatibility
bool?, an int toint?)Testing
Describe how this change was tested.
Test Steps
Screenshots (if applicable)
Include config page screenshots or request/response samples where relevant.
Before
After
Checklist