feat: add achievements plugin friends feature - #304
Merged
RadicalMuffinMan merged 4 commits intoSep 30, 2026
Merged
RadicalMuffinMan merged 4 commits into
RadicalMuffinMan merged 4 commits into
Conversation
Merged
10 of 24 tasks
Build SuccessfulBoth plugins compiled against .NET 8, and both test suites passed.
|
…le model so both ports keep the same settings keys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Moonfin-Core adds a Friends button for the Achievement Badges plugin's friends and chat. This adds its setting to the profile, so it syncs across devices like the other nav buttons, and lets an admin set a default.
Needs the matching Moonfin-Core PR : Moonfin-Client/Moonfin-Core#1695
Related Issues
Type of Change
Area
Changes Made
ShowFriendsButtoninMoonfinSettingsProfile, next toShowServerMessagesButton.Client Impact
feat/implement-achievments-friendsshowFriendsButton: matchesSyncedField('showFriendsButton', …)inlib/data/services/synced_fields.dart.Compatibility
bool?, an int toint?)One new
bool?, nothing renamed, so no migration. Older clients never send the key.Testing
Builds with no warnings.
Test Steps
Screenshots (if applicable)
Checklist