Make tesseract bring along its own dependencies instead of relying on system packages being available#425
Closed
duckduckgrayduck wants to merge 1 commit into
Closed
Make tesseract bring along its own dependencies instead of relying on system packages being available#425duckduckgrayduck wants to merge 1 commit into
duckduckgrayduck wants to merge 1 commit into
Conversation
Contributor
|
This works in local testing. Should we add these binary files to git lfs? |
Contributor
Author
|
They're all pretty small. Since they're less than 100MB I think we can go without. We use lfs for libreoffice mostly |
Contributor
|
The main reason I'd put them in LFS is that we don't want git storing multiple versions of them, and git is bad at binary files. |
Member
|
I imagine these are going to change extremely infrequently, so I think sticking with normal git is fine. |
eyeseast
approved these changes
Jul 8, 2026
Contributor
|
I can be outvoted. I'll close out the other one and we can merge this. |
Merged
Contributor
Author
|
Didn't see these comments- I have a new branch open with LFS which is probably the better approach longer term. Happy to merge it if it works |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can decide collectively whether this or #420 is a better approach