logstash: delete rotated log files at rollover - #525
Open
Saeid-Abadi wants to merge 1 commit into
Open
Conversation
The managed log4j2 configuration rotated files but never deleted them, so
/var/log/logstash grew indefinitely (one .gz per day, per appender, since
first deployment). The DefaultRolloverStrategy max attribute is not enough
here because filePattern combines %d{yyyy-MM-dd} with %i, which restarts the
counter on every new day.
Add a Delete action to every RollingFile appender (plain, json, slowlog
plain, slowlog json, deprecation and the per-pipeline routing appender),
filtered by the appender's own filename glob and IfLastModified. This
restores the behaviour Elastic ships for the plain and json appenders and
extends it to the appenders where the vendor default is also incomplete.
The retention is controlled by logstash_logging_retention, default 7D,
matching Elastic. Any log4j2 IfLastModified duration works, e.g. 24H or
P30D.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The managed log4j2 configuration rotated files but never deleted them, so /var/log/logstash grew indefinitely (one .gz per day, per appender, since first deployment). The DefaultRolloverStrategy max attribute is not enough here because filePattern combines %d{yyyy-MM-dd} with %i, which restarts the counter on every new day.
Add a Delete action to every RollingFile appender (plain, json, slowlog plain, slowlog json, deprecation and the per-pipeline routing appender), filtered by the appender's own filename glob and IfLastModified. This restores the behaviour Elastic ships for the plain and json appenders and extends it to the appenders where the vendor default is also incomplete.
The retention is controlled by logstash_logging_retention, default 7D, matching Elastic. Any log4j2 IfLastModified duration works, e.g. 24H or P30D.