Skip to content

Adds additional loss functions#262

Merged
jonasteuwen merged 4 commits into
mainfrom
funs
Mar 22, 2024
Merged

Adds additional loss functions#262
jonasteuwen merged 4 commits into
mainfrom
funs

Conversation

@georgeyiasemis

Copy link
Copy Markdown
Contributor

Adds:

  • High frequency error norm (hfen) as loss and metric
  • Signal-to-noise ratio (snr) loss
  • SSIM 3d loss
  • Tests

@codecov

codecov Bot commented Mar 22, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 88.73239% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 84.05%. Comparing base (39e7680) to head (aec9327).

Files Patch % Lines
direct/functionals/hfen.py 81.08% 14 Missing ⚠️
direct/nn/mri_models.py 87.93% 7 Missing ⚠️
direct/functionals/snr.py 87.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #262      +/-   ##
==========================================
- Coverage   84.40%   84.05%   -0.36%     
==========================================
  Files          93       93              
  Lines        6645     6486     -159     
==========================================
- Hits         5609     5452     -157     
+ Misses       1036     1034       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonasteuwen jonasteuwen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but some minor comments.

Comment thread direct/functionals/__init__.py
Comment thread direct/functionals/ssim.py
Comment thread direct/nn/mri_models.py Outdated

@jonasteuwen jonasteuwen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonasteuwen jonasteuwen merged commit b56a724 into main Mar 22, 2024
@georgeyiasemis georgeyiasemis deleted the funs branch March 23, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants