Implements vSHARP model (2D)#271
Merged
Merged
Conversation
georgeyiasemis
commented
Mar 25, 2024
Contributor
- This PR introduces the variable Splitting Half-quadratic ADMM algorithm for Reconstruction of inverse-Problems (vSHARP) model as presented in https://arxiv.org/abs/2309.09954.
- It includes experiment files as presented in the paper for the fastmri prostate dataset.
- It implements tests for vSHARP
- Contains minor changes that allow None for masking function.
- Updates main README file.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #271 +/- ##
==========================================
+ Coverage 84.08% 84.34% +0.25%
==========================================
Files 93 95 +2
Lines 6504 6631 +127
==========================================
+ Hits 5469 5593 +124
- Misses 1035 1038 +3 ☔ View full report in Codecov by Sentry. |
jonasteuwen
reviewed
Mar 26, 2024
jonasteuwen
left a comment
Contributor
There was a problem hiding this comment.
Looks good, only a few minor comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.