Skip to content

fix(camera): default zfar equals znear making projection (+1 more) - #6

Open
andrewwhitecdw wants to merge 1 commit into
NVIDIA:masterfrom
andrewwhitecdw:bugfix/camera-assorted-ae5c5fac
Open

andrewwhitecdw wants to merge 1 commit into
NVIDIA:masterfrom
andrewwhitecdw:bugfix/camera-assorted-ae5c5fac

Conversation

@andrewwhitecdw

@andrewwhitecdw andrewwhitecdw commented Jul 27, 2026 •

Copy link
Copy Markdown

This PR addresses 2 issues in nvdu/core/camera.py.

Fix 1

fix: default zfar equals znear making projection degenerate

Fix: Replace:

    DEFAULT_ZNEAR = 1
    # DEFAULT_ZFAR = 100000.0
    DEFAULT_ZFAR = DEFAULT_ZNEAR

with:

    DEFAULT_ZNEAR = 1
    DEFAULT_ZFAR = 100000.0

Fix 2

fix: Camera str method missing self argument

Fix: Replace:

    def str():
        return "{}".format(self.get_intrinsic_matrix())

with:

    def str(self):
        return "{}".format(self.get_intrinsic_matrix())

Files changed

  • nvdu/core/camera.py

@andrewwhitecdw
andrewwhitecdw marked this pull request as ready for review July 27, 2026 21:12
@andrewwhitecdw

Copy link
Copy Markdown
Author

Closing this sweep-generated PR: sole commit is missing a valid Signed-off-by trailer. It does not meet the sweep requirements (single signed-off commit).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant