fix(kafka_protocol_adaptor): correct RDKAFKA_INC for apt-installed librdkafka-dev - #4
Merged
Merged
Conversation
…brdkafka-dev apt install librdkafka-dev (per the adaptor README) lands rdkafka.h at /usr/include/librdkafka/, not /usr/local/include/librdkafka/. Revert RDKAFKA_INC to /usr/include/librdkafka to match the public DS 9.0 Makefile and unbreak `sudo make` in the kafka adaptor directory. Ported from internal GitLab mono-repo MR !92 (commit f4ad051), validated on x86 with librdkafka-dev 2.3.0-1build2 from Ubuntu noble. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Committed-By: ankitat's Claude Agent Codex Review: Approved:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sudo makeinsidesrc/utils/nvds_msgapi/kafka_protocol_adaptor/failed with:```
kafka_client.h:19:10: fatal error: rdkafka.h: No such file or directory
19 | #include "rdkafka.h"
```
The adaptor's
Makefilehard-codedRDKAFKA_INC=/usr/local/include/librdkafka, but the adaptor's README directs users toapt install librdkafka-dev, which places the header at/usr/include/librdkafka/. RevertedRDKAFKA_INCto/usr/include/librdkafka— matches the public DS 9.0 release Makefile that this tree was originally derived from.Root cause
The line was a divergence from the public DS 9.0 source that snuck in during initial mono-repo import; it travelled here when the mono-repo's
src/tree was migrated to this GitHub repo in PR #2. SQA flagged it while trying the manualsudo makeflow documented in the adaptor README.Validation
f4ad051):sudo make NVDS_VERSION=9.0produceslibnvds_kafka_proto.socleanly withlibrdkafka-dev 2.3.0-1build2+libjansson-dev 2.14-2build2from Ubuntu noble.Follow-ups (not in this PR)
NVDS_VERSIONhas no default in the kafka Makefile, so directsudo make(withoutNVDS_VERSION=9.0) expands the install path to/opt/nvidia/deepstream/deepstream-/lib/. Either defaultNVDS_VERSION ?= 9.0in the Makefile or note it in the adaptor README.build.shmsgapi loop silently ignores failures (make ... 2>/dev/null || true) — should be tightened so future adaptor regressions surface.