Skip to content

perf(gdn): preserve Qwen3.5 H100 integration stack - #6370

Closed
yaoyu-33 wants to merge 25 commits into
NVIDIA:mainfrom
yaoyu-33:yuya/qwen35-h100-285-integration
Closed

perf(gdn): preserve Qwen3.5 H100 integration stack#6370
yaoyu-33 wants to merge 25 commits into
NVIDIA:mainfrom
yaoyu-33:yuya/qwen35-h100-285-integration

Conversation

@yaoyu-33

@yaoyu-33 yaoyu-33 commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Purpose

This draft preserves the exact public Megatron-Core integration used by the
Qwen3.5-35B-A3B 16xH100 model-card benchmark in
NVIDIA-NeMo/Megatron-Bridge#5098. It is a reproducibility ref while the source
upstream changes remain in flight.

Measured runtime commit:
606c01046bf411c54e730739844da9e613f84a76.

Current PR head:
323c5bdf72ac62e6249308fe5adfd22e9a1e243a.
Descendants of the measured commit update tests and repair the deterministic
torch fallback's FLA 0.4.2 l2norm call signature. The measured FlashQLA
performance path is unchanged.

Integrated upstream work

The branch also carries adaptations of #5982 and #5396. They are inactive in
the accepted no-recompute, pre-GDR-fused path and are not credited for the
measured result.

Frozen runtime contract

  • flash-linear-attention==0.4.2
  • flash-qla==0.1.2
  • transitive tilelang==0.1.9 and apache-tvm-ffi==0.1.9
  • lazy FlashQLA loading fails closed unless the runtime is exactly 0.1.2
  • fused gated RMSNorm is adapted to the refactored GDN path

The complete kernel stack is exposed through the opt-in
qwen35-h100-perf extra. It is explicitly incompatible with MCore's existing
ssm extra because that runtime currently requires TileLang 0.1.8.

Reproducibility scope

Bridge #5449 pins the current test-hardened PR head and supplies a hash-locked
container overlay;
stacked Bridge #5098 owns the recipe and model-card evidence. The benchmark
uses mock data and forced expert balancing, so it is performance stability
evidence rather than convergence evidence.

Validation

  • exact dependency pins and public artifacts are represented in uv.lock
  • focused FlashQLA version-contract tests passed on H100
  • Black formatting issue from the first CI attempt was fixed at the frozen
    head
  • deterministic-mode coverage explicitly selects its required torch backend
  • deterministic GDN/GDN2 fallbacks match the pinned FLA 0.4.2 l2norm
    interface
  • current-head GDN unit coverage, the broad SSM suite, and GB200 unit coverage
    pass
  • all four affected current-head GDN functional jobs pass:
    gpt3_mcore_te_tp2_pp1_gdn, gdn_no_nvrx_async,
    gdn_no_nvrx_async_mcore, and gdn_no_nvrx_sync
  • Black, isort, Ruff, DCO, installation, wheel, docs, and copyright checks
    pass; code-owner approval remains expected for merge

xuantengh and others added 19 commits August 3, 2026 05:25
Signed-off-by: Xuanteng Huang <xuantengh@nvidia.com>
Signed-off-by: Xuanteng Huang <xuantengh@nvidia.com>
Signed-off-by: Xuanteng Huang <xuantengh@nvidia.com>
Signed-off-by: Xuanteng Huang <xuantengh@nvidia.com>
Signed-off-by: Xuanteng Huang <xuantengh@nvidia.com>
Signed-off-by: Xuanteng Huang <xuantengh@nvidia.com>
Signed-off-by: Xuanteng Huang <xuantengh@nvidia.com>
Signed-off-by: Xuanteng Huang <xuantengh@nvidia.com>
Signed-off-by: Xuanteng Huang <xuantengh@nvidia.com>
Signed-off-by: Xuanteng Huang <xuantengh@nvidia.com>
Signed-off-by: Xuanteng Huang <xuantengh@nvidia.com>
Signed-off-by: Yu Yao <yuya@nvidia.com>
Signed-off-by: Yu Yao <yuy@nvidia.com>
Signed-off-by: Yu Yao <yuy@nvidia.com>
Signed-off-by: Yu Yao <yuya@nvidia.com>
Signed-off-by: Yu Yao <yuya@nvidia.com>
Signed-off-by: Yu Yao <yuya@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Aug 8, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Signed-off-by: Yu Yao <yuya@nvidia.com>
@yaoyu-33

yaoyu-33 commented Aug 8, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test ca330d1

@yaoyu-33

yaoyu-33 commented Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 9f347b3

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
@yaoyu-33

yaoyu-33 commented Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 323c5bd

@yaoyu-33

yaoyu-33 commented Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

Freeze/validation note for current HEAD 323c5bdf72:

  • All executable CI tests completed successfully, including current-head GDN unit coverage, the broad SSM suite, GB200 unit coverage, and all four affected GDN functional jobs.
  • The remaining failures are merge-policy gates: code-owner approval, multi-approval, and Codecov patch coverage (25.74% vs 80%).
  • The Codecov result reflects the large integrated upstream diff preserved by this reproducibility PR. It is not a failure of the Qwen3.5 model-card reproduction or measured FlashQLA path.
  • Per the campaign freeze, no further performance exploration or unrelated coverage expansion is being added here.

@yaoyu-33
yaoyu-33 marked this pull request as ready for review August 9, 2026 08:59
@yaoyu-33
yaoyu-33 requested review from a team as code owners August 9, 2026 08:59
@yaoyu-33 yaoyu-33 closed this Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants