Optixir fixes - #25
Merged
Merged
Conversation
Collaborator
|
Hey, Lewis, Only two comments from eyeballing the diff:
|
Author
|
Hi Ingo, Thanks for merging this! My code won't compile without the "extern C", and complains about undefined references to the *_optixir_length variables. Lewis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I was trying to transition from PTX to optixir in my OWL application and ran into some issues getting optixir to work.
This patch fixes those issues by broadly copying what embed_ptx does, but applying it to embed_optixir.
Mainly changing the file extension of the generated file, and harmonising the add_library call and adding the set_target_properties calls.
I'm not too familiar with all this PTX/OPTIXIR stuff and not great with cmake, so I've probably gone wrong somewhere.
It does now work on my machine...
Lewis